Add type replacement annotations to simplify rust binding generation for nsStyleStruct.h

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

(Blocks: 1 bug)

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160319124722

Steps to reproduce:

Patch to generate replacements for some structs which generate complex bindings in nsStyleStruct.h
(Assignee)

Comment 1

2 years ago
Created attachment 8734842 [details] [diff] [review]
Add ns* structs replacement
Comment on attachment 8734842 [details] [diff] [review]
Add ns* structs replacement

Review of attachment 8734842 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fix.

::: layout/style/nsStyleStruct.h
@@ +102,3 @@
>  
> +/**
> + * If something in this types or the assertions below needs to change, ask

I would add an explanation here that these are used to map Gecko types to simpler layout-equivalent types to aid rust binding generation.
Attachment #8734842 - Flags: review+
Assignee: nobody → ecoal95
Blocks: 1243581
Summary: stylo: Required patch for sane rust bindings → Add type replacement annotations to simplify rust binding generation for nsStyleStruct.h
(Assignee)

Comment 3

2 years ago
Created attachment 8734849 [details] [diff] [review]
0001-Bug-1259802-Add-type-replacement-annotations-to-simp.patch
Attachment #8734842 - Attachment is obsolete: true
Attachment #8734849 - Flags: review?(bobbyholley)
(Assignee)

Comment 4

2 years ago
(In reply to Bobby Holley (busy) from comment #2)
> Comment on attachment 8734842 [details] [diff] [review]
> Add ns* structs replacement
> 
> Review of attachment 8734842 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with that fix.
> 
> ::: layout/style/nsStyleStruct.h
> @@ +102,3 @@
> >  
> > +/**
> > + * If something in this types or the assertions below needs to change, ask
> 
> I would add an explanation here that these are used to map Gecko types to
> simpler layout-equivalent types to aid rust binding generation.

Done
Attachment #8734849 - Flags: review?(bobbyholley) → review+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/745c69669283
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.