1259802 - Add type replacement annotations to simplify rust binding generation for nsStyleStruct.h

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160319124722

Steps to reproduce:

Patch to generate replacements for some structs which generate complex bindings in nsStyleStruct.h

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Add ns* structs replacement

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8734842 [details] [diff] [review]
Add ns* structs replacement

Review of attachment 8734842 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fix.

::: layout/style/nsStyleStruct.h
@@ +102,3 @@
>  
> +/**
> + * If something in this types or the assertions below needs to change, ask

I would add an explanation here that these are used to map Gecko types to simpler layout-equivalent types to aid rust binding generation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: 0001-Bug-1259802-Add-type-replacement-annotations-to-simp.patch

Comment 4

[Emilio Cobos Álvarez [:emilio]]

(In reply to Bobby Holley (busy) from comment #2)
> Comment on attachment 8734842 [details] [diff] [review]
> Add ns* structs replacement
> 
> Review of attachment 8734842 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with that fix.
> 
> ::: layout/style/nsStyleStruct.h
> @@ +102,3 @@
> >  
> > +/**
> > + * If something in this types or the assertions below needs to change, ask
> 
> I would add an explanation here that these are used to map Gecko types to
> simpler layout-equivalent types to aid rust binding generation.

Done

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/745c69669283

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/745c69669283