1259876 - A define in mobile/android/installer/moz.build will not make it to mobile/android/installer/package-manifest.in

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

This moz.build actually isn't read, because no parent has 'installer' in dirs (right now it's empty, so that's fine). But even with that, mobile/android/installer/Makefile.in defines STANDALONE_MAKEFILE, so backend.mk isn't included once we generate it.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

... but since that's the only thing setting STANDALONE_MAKEFILE does, we can just leave that out.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1259876 - Ensure defines in mobile/android/installer/moz.build make it to mobile/android/installer/package-manifest.in. r=nalexander

Review commit: https://reviewboard.mozilla.org/r/42517/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42517/

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8735013 [details]
MozReview Request: Bug 1259876 - Ensure defines in mobile/android/installer/moz.build make it to mobile/android/installer/package-manifest.in. r=nalexander

https://reviewboard.mozilla.org/r/42517/#review39031

I'm fine with this, but none of the other `installer/Makefile.in` need it.  Perhaps the l10n preprocessing shoudl be happening somewhere else?

Comment 4

[Mike Hommey [:glandium]]

You probably don't want to open the can of worms that adding a moz.build to an installer directory is.
It might work, but that would be luck, and would be pretty much fragile.