Obviate char PORT_Free() calls in PSM

RESOLVED FIXED in Firefox 48

Status

()

Core
Security: PSM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Smart pointers should be used to manage char* resources returned via NSS calls for better maintainability and robustness.
(Assignee)

Updated

2 years ago
Summary: Obviate string PORT_Free() calls in PSM → Obviate char PORT_Free() calls in PSM
(Assignee)

Comment 1

2 years ago
Created attachment 8739343 [details]
MozReview Request: Bug 1259909 - Obviate char PORT_Free() calls in PSM. r=keeler

Also converts the longer |UniquePtr<char, void(&)(void*)> foo(..., PORT_Free)|
to the shorter and equivalent |UniquePORTString foo(...)|.

Review commit: https://reviewboard.mozilla.org/r/45207/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45207/
Attachment #8739343 - Flags: review?(dkeeler)
Comment on attachment 8739343 [details]
MozReview Request: Bug 1259909 - Obviate char PORT_Free() calls in PSM. r=keeler

https://reviewboard.mozilla.org/r/45207/#review41791

Great - r=me.
Attachment #8739343 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 3

2 years ago
Comment on attachment 8739343 [details]
MozReview Request: Bug 1259909 - Obviate char PORT_Free() calls in PSM. r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45207/diff/1-2/
Attachment #8739343 - Attachment description: MozReview Request: Bug 1259909 - Obviate char PORT_Free() calls in PSM. → MozReview Request: Bug 1259909 - Obviate char PORT_Free() calls in PSM. r=keeler

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7a50cf3a5b57
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.