1259909 - Obviate char PORT_Free() calls in PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

Smart pointers should be used to manage char* resources returned via NSS calls for better maintainability and robustness.

Comment 1

[:Cykesiopka]

Attachment: MozReview Request: Bug 1259909 - Obviate char PORT_Free() calls in PSM. r=keeler

Also converts the longer |UniquePtr<char, void(&)(void*)> foo(..., PORT_Free)|
to the shorter and equivalent |UniquePORTString foo(...)|.

Review commit: https://reviewboard.mozilla.org/r/45207/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45207/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8739343 [details]
MozReview Request: Bug 1259909 - Obviate char PORT_Free() calls in PSM. r=keeler

https://reviewboard.mozilla.org/r/45207/#review41791

Great - r=me.

Comment 3

[:Cykesiopka]

Comment on attachment 8739343 [details]
MozReview Request: Bug 1259909 - Obviate char PORT_Free() calls in PSM. r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45207/diff/1-2/

Comment 4

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3839aa7e3c741c683b6b854981cd0309fffe4cbe

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a50cf3a5b57

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a50cf3a5b57