Closed Bug 1259925 Opened 4 years ago Closed 4 years ago

Port ModuleNamespace getprop stub to CacheIR

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
This is where this design starts to pay off:

  7 files changed, 54 insertions(+), 157 deletions(-)

And that's just the Baseline part. Once we add the Ion backend there will be more code to remove from IonCaches.cpp
Attachment #8735118 - Flags: review?(efaustbmo)
Blocks: CacheIR
No longer blocks: 1255352
Comment on attachment 8735118 [details] [diff] [review]
Patch

Review of attachment 8735118 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8735118 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/72235ad4fc17
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.