Closed
Bug 1259949
Opened 8 years ago
Closed 8 years ago
<textarea> displays caret on wrong line after selecting \n if it's the last symbol
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
VERIFIED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | verified |
People
(Reporter: arni2033, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
(Keywords: testcase)
Attachments
(3 files)
192 bytes,
text/html
|
Details | |
2.09 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
6.81 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
>>> My Info: Win7_64, Nightly 48, 32bit, ID 20160324030447
STR:
1. Open attached "testcase 1" (text in <textarea> is "asdf\n")
2. Select any text including the last "\n" in testcase, for example:
Click between "s" and "d", press Shift+Down to select "df\n"
3. Press Right key to move cursor to the end of text selection
4. Type "x"
Result:
After Step 3 cursor is displayed at the end of the 1st line
After Step 4 the typed letter ("x") appears in the beginning of the 2nd line
Expectations:
After Step 3 cursor should be displayed at the start of the 2nd line
Comment hidden (spam) |
Assignee | ||
Comment 2•8 years ago
|
||
In this case we have a DOM like so: <anonymous-div> "asdf\n" <br> and we Collapse() at <anonymous-div> : 1 So that makes do_QueryFrame(aParentNode.AsContent()->GetPrimaryFrame()) null since the frame we get there isn't a text frame - it's a scroll frame for the <anonymous-div>. To my surprise though, nsCaret::GetFrameAndOffset seems to deal with this and does return the text frame (if I remove the initial null-check on 'f'). We would need to tweak the aOffset check on line 4948 though since it isn't a text offset in this case. http://hg.mozilla.org/mozilla-central/annotate/63be002b4a80/layout/generic/nsSelection.cpp#l4940
Assignee | ||
Comment 3•8 years ago
|
||
(see explanation of the problem in comment 2)
Attachment #8735256 -
Flags: review?(ehsan)
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2612040c9605
Updated•8 years ago
|
Attachment #8735256 -
Flags: superreview+
Updated•8 years ago
|
Attachment #8735256 -
Flags: superreview+
Attachment #8735256 -
Flags: review?(ehsan)
Attachment #8735256 -
Flags: review+
Updated•8 years ago
|
Attachment #8735257 -
Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e97b6bf18de https://hg.mozilla.org/integration/mozilla-inbound/rev/74f7a5eba75e
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2e97b6bf18de https://hg.mozilla.org/mozilla-central/rev/74f7a5eba75e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Updated•8 years ago
|
Flags: in-testsuite+
Fixed on: Win7_64, Nightly 48, 32bit, ID 20160401030216 Bug 1237286 is still reproducible
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•