Closed Bug 1260032 Opened 4 years ago Closed 4 years ago

drop support for altGlyph

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file, 1 obsolete file)

It's been dropped from SVG 2.
Attached patch altglyph.txt (obsolete) — Splinter Review
Attachment #8735270 - Flags: review?(cam)
Assignee: nobody → longsonr
Comment on attachment 8735270 [details] [diff] [review]
altglyph.txt

Review of attachment 8735270 [details] [diff] [review]:
-----------------------------------------------------------------

Very sorry for the delay, again.

The patch looks good.  Neither Chrome nor Edge support the <altGlyph> -> <tspan> fallback behaviour (which is what is being removed here and is most at risk of being used), though Safari still does.  I think it's safe to remove without telemetry.

Please make sure to get a DOM peer's review.

I wonder if, in the spirit of sending intent emails more consistently, we should send an Intent to Unimplement to dev-platform about this?

::: dom/system/gonk/tests/marionette/ril_jshint/jshint.js
@@ -416,5 @@
>  	status               : false,
>  	SVGAElement          : false,
> -	SVGAltGlyphDefElement: false,
> -	SVGAltGlyphElement   : false,
> -	SVGAltGlyphItemElement: false,

This is an imported library so I don't think we should change it.

::: layout/reftests/svg/nesting-invalid-01.js
@@ +1,4 @@
>  // Any copyright is dedicated to the Public Domain.
>  // http://creativecommons.org/publicdomain/zero/1.0/
>  
>  // These are all of the SVG 1.1 element names, except for container elements,

Can you update this comment to be more accurate?
Attachment #8735270 - Flags: review?(cam) → review+
Keywords: dev-doc-needed
Whiteboard: dev-doc-needed
Keywords: site-compat
Whiteboard: dev-doc-needed
The webidl changes need a DOM peer review, even though they are only removal.
Attachment #8735270 - Attachment is obsolete: true
Attachment #8750123 - Flags: review?(peterv)
Attachment #8750123 - Attachment is patch: true
Attachment #8750123 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/9cf2c93a154e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
<altGlyphDef> and <altGlyphItem> have never been supported so it's a bit misleading to say that support has been dropped.
Thanks! Removed <altGlyphDef> and <altGlyphItem> from the doc.
You need to log in before you can comment on or make changes to this bug.