Closed
Bug 1260032
Opened 7 years ago
Closed 7 years ago
drop support for altGlyph
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file, 1 obsolete file)
18.81 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
It's been dropped from SVG 2.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8735270 -
Flags: review?(cam)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → longsonr
Comment 2•7 years ago
|
||
Comment on attachment 8735270 [details] [diff] [review] altglyph.txt Review of attachment 8735270 [details] [diff] [review]: ----------------------------------------------------------------- Very sorry for the delay, again. The patch looks good. Neither Chrome nor Edge support the <altGlyph> -> <tspan> fallback behaviour (which is what is being removed here and is most at risk of being used), though Safari still does. I think it's safe to remove without telemetry. Please make sure to get a DOM peer's review. I wonder if, in the spirit of sending intent emails more consistently, we should send an Intent to Unimplement to dev-platform about this? ::: dom/system/gonk/tests/marionette/ril_jshint/jshint.js @@ -416,5 @@ > status : false, > SVGAElement : false, > - SVGAltGlyphDefElement: false, > - SVGAltGlyphElement : false, > - SVGAltGlyphItemElement: false, This is an imported library so I don't think we should change it. ::: layout/reftests/svg/nesting-invalid-01.js @@ +1,4 @@ > // Any copyright is dedicated to the Public Domain. > // http://creativecommons.org/publicdomain/zero/1.0/ > > // These are all of the SVG 1.1 element names, except for container elements, Can you update this comment to be more accurate?
Attachment #8735270 -
Flags: review?(cam) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://groups.google.com/forum/#!topic/mozilla.dev.platform/LcN2jd9gGiM
Updated•7 years ago
|
Keywords: dev-doc-needed
Whiteboard: dev-doc-needed
Updated•7 years ago
|
Keywords: site-compat
Whiteboard: dev-doc-needed
Assignee | ||
Comment 4•7 years ago
|
||
The webidl changes need a DOM peer review, even though they are only removal.
Attachment #8735270 -
Attachment is obsolete: true
Attachment #8750123 -
Flags: review?(peterv)
Assignee | ||
Updated•7 years ago
|
Attachment #8750123 -
Attachment is patch: true
Assignee | ||
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbdf4bba325
Updated•7 years ago
|
Attachment #8750123 -
Flags: review?(peterv) → review+
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9cf2c93a154e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 8•7 years ago
|
||
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/altglyph-is-no-longer-supported/
Assignee | ||
Comment 9•7 years ago
|
||
<altGlyphDef> and <altGlyphItem> have never been supported so it's a bit misleading to say that support has been dropped.
Comment 10•7 years ago
|
||
Thanks! Removed <altGlyphDef> and <altGlyphItem> from the doc.
Comment 11•7 years ago
|
||
MDN has been updated: * https://developer.mozilla.org/en-US/Firefox/Releases/49 * https://developer.mozilla.org/en-US/docs/Web/SVG/Element/altGlyph * https://developer.mozilla.org/en-US/docs/Web/SVG/Element/altGlyphDef * https://developer.mozilla.org/en-US/docs/Web/SVG/Element/altGlyphItem
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•