1260032 - drop support for altGlyph

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

It's been dropped from SVG 2.

Comment 1

[Robert Longson [:longsonr]]

Attachment: altglyph.txt

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8735270 [details] [diff] [review]
altglyph.txt

Review of attachment 8735270 [details] [diff] [review]:
-----------------------------------------------------------------

Very sorry for the delay, again.

The patch looks good.  Neither Chrome nor Edge support the <altGlyph> -> <tspan> fallback behaviour (which is what is being removed here and is most at risk of being used), though Safari still does.  I think it's safe to remove without telemetry.

Please make sure to get a DOM peer's review.

I wonder if, in the spirit of sending intent emails more consistently, we should send an Intent to Unimplement to dev-platform about this?

::: dom/system/gonk/tests/marionette/ril_jshint/jshint.js
@@ -416,5 @@
>  	status               : false,
>  	SVGAElement          : false,
> -	SVGAltGlyphDefElement: false,
> -	SVGAltGlyphElement   : false,
> -	SVGAltGlyphItemElement: false,

This is an imported library so I don't think we should change it.

::: layout/reftests/svg/nesting-invalid-01.js
@@ +1,4 @@
>  // Any copyright is dedicated to the Public Domain.
>  // http://creativecommons.org/publicdomain/zero/1.0/
>  
>  // These are all of the SVG 1.1 element names, except for container elements,

Can you update this comment to be more accurate?

Comment 3

[Robert Longson [:longsonr]]

https://groups.google.com/forum/#!topic/mozilla.dev.platform/LcN2jd9gGiM

Comment 4

[Robert Longson [:longsonr]]

Attachment: address review comments

The webidl changes need a DOM peer review, even though they are only removal.

Comment 5

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbdf4bba325

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9cf2c93a154e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9cf2c93a154e

Comment 8

[Kohei Yoshino [:kohei]]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/altglyph-is-no-longer-supported/

Comment 9

[Robert Longson [:longsonr]]

<altGlyphDef> and <altGlyphItem> have never been supported so it's a bit misleading to say that support has been dropped.

Comment 10

[Kohei Yoshino [:kohei]]

Thanks! Removed <altGlyphDef> and <altGlyphItem> from the doc.

Comment 11

[Jeremie Patonnier :Jeremie]

MDN has been updated:

* https://developer.mozilla.org/en-US/Firefox/Releases/49
* https://developer.mozilla.org/en-US/docs/Web/SVG/Element/altGlyph
* https://developer.mozilla.org/en-US/docs/Web/SVG/Element/altGlyphDef
* https://developer.mozilla.org/en-US/docs/Web/SVG/Element/altGlyphItem