1260287 - Display a warning message when console.log (&info, error, etc) are overridden

Status: NEW

(DevTools :: Console, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

> window.console = myCustomConsoleObject;

If a page overrides the console object, the devtools webconsole displays a warning message : "The Web Console logging API (console.log, console.info, console.warn, console.error) has been disabled by a script on this page".

> window.console.log = function() {};

If a page only overrides the log/info/warn/error methods, no message is displayed. A similar message should also be displayed in this case. (real life example of this: twitter.com disables logging by overriding each method of the Console object)

Sidenote: the message is a bit misleading. We don't actually check if the logging has been disabled, but only that it has been modified. Maybe we should log "The Web Console logging API (console.log, console.info, console.warn, console.error) has been modified by a script on this page. It might be disabled or behave unexpectedly."

Comment 1

[Brian Grinstead [:bgrins]]

Relevant code for the console object overriding detection (hasNativeConsoleAPI): https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/webconsole.js#321