126029 - cvsblame does not HTML escape log messages

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, defect, P1)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

If the log contains < > or & then we need to escape it.

As an example, in the URL hover over:  bzbarsky 1.46

The HTML output is as follows.

<div id="rev_1.46" class="log_msg" style="display:none"><b>1.46</b> &lt;<a
href='mailto:[e-mail]'>[e-mail]</a>&gt; <b>24 Jan 2002
13:19</b><br><spacer TYPE=VERTICAL SIZE=5>Make computed border-style and float
be "none" by default.  Bugs <a
HREF="http://bugzilla.mozilla.org/show_bug.cgi?id=120982">120982</a><br>and <a
HREF="http://bugzilla.mozilla.org/show_bug.cgi?id=120965">120965</a>, patch by
Christopher Aillon <[e-mail]>,<br>r=bzbarsky, sr=jst<br></div>


PS - I'm flattered that you want my email address as an HTML element.  I'll
support any efforts to take it up with the w3c ;-)

Comment 1

[Johnny Stenback (:jst)]

Argh, this is really annoying. Try loading
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/html/document/src/nsHTMLContentSink.cpp
and you'll notice that you're redirected to http://bonsai.mozilla.org/URI, and
that's because a checkin comment contains:

  <meta http-equiv="refresh" content="X; url=URI">

Not good.

Comment 2

[Jacob Steenhagen]

Attachment: Patch

Fixes this bug and cleans up a couple other minor issues (funny word wraping
and a //-> printed at the bottom of the page).

Comment 3

[Jacob Steenhagen]

There are a lot of other uglies in this file, but I guess we can save those for
another day :)

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 70409 [details] [diff] [review]
Patch

r=caillon

Comment 5

[Jacob Steenhagen]

Checked in.

Comment 6

[timeless]

this is r1.30 we need it pulled to bonsai because it's causing bad things to happen...

Comment 7

[Johnny Stenback (:jst)]

Reopening since I new see this same problem again.

Comment 8

[timeless]

endico would you please cvsupdate bonsai to catch this?

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 135872 has been marked as a duplicate of this bug. ***

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

yay.  sleestack updated bonsai the other night to grab this fix.  resolving.