Closed
Bug 1260321
Opened 9 years ago
Closed 9 years ago
Follow-up: Migrate users with customized panels to combined history panel
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: liuche, Assigned: liuche)
References
Details
Attachments
(1 file)
Migrate users with custom home panels that contain History or Synced panels to the Combined History panel, and remove all the other code that we no longer need.
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44377/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44377/
Attachment #8738233 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 2•9 years ago
|
||
I tested this with no panels enabled, just history enabled, just sync enabled by upgrading from an older version that didn't have the new sync panels.
I built from the changeset before combined history/synced panels landed: https://hg.mozilla.org/integration/fx-team/rev/69f271e79c56
(the build I used is http://people.mozilla.org/~liuche/bug-1260321/old-panels.apk )
Updated•9 years ago
|
Assignee: nobody → liuche
Comment 3•9 years ago
|
||
Comment on attachment 8738233 [details]
MozReview Request: Bug 1260321 - Follow-up: Migrate users with customized panels to combined history panel. r=sebastian
https://reviewboard.mozilla.org/r/44377/#review41691
::: mobile/android/base/java/org/mozilla/gecko/home/HomeConfigPrefsBackend.java:178
(Diff revision 1)
> + if (historyIndex == -1 || syncIndex == -1) {
> + throw new IllegalArgumentException("Missing default panels");
> + }
Can we assume that this is never going to happen and we do not have any index bugs? Otherwise we could throw JSONException and fall back to the default config instead of crashing? But then again if we don't see this crash while this rides the trains then everything should be okay.
Attachment #8738233 -
Flags: review?(s.kaspari) → review+
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•