1260321 - Follow-up: Migrate users with customized panels to combined history panel

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Migrate users with custom home panels that contain History or Synced panels to the Combined History panel, and remove all the other code that we no longer need.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1260321 - Follow-up: Migrate users with customized panels to combined history panel. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/44377/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44377/

Comment 2

[Chenxia Liu [:liuche]]

I tested this with no panels enabled, just history enabled, just sync enabled by upgrading from an older version that didn't have the new sync panels.

I built from the changeset before combined history/synced panels landed: https://hg.mozilla.org/integration/fx-team/rev/69f271e79c56

(the build I used is http://people.mozilla.org/~liuche/bug-1260321/old-panels.apk )

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8738233 [details]
MozReview Request: Bug 1260321 - Follow-up: Migrate users with customized panels to combined history panel. r=sebastian

https://reviewboard.mozilla.org/r/44377/#review41691

::: mobile/android/base/java/org/mozilla/gecko/home/HomeConfigPrefsBackend.java:178
(Diff revision 1)
> +        if (historyIndex == -1 || syncIndex == -1) {
> +            throw new IllegalArgumentException("Missing default panels");
> +        }

Can we assume that this is never going to happen and we do not have any index bugs? Otherwise we could throw JSONException and fall back to the default config instead of crashing? But then again if we don't see this crash while this rides the trains then everything should be okay.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fef9283ad53a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fef9283ad53a