Closed
Bug 1260353
Opened 8 years ago
Closed 8 years ago
Remove unnecessary method AnimValuesStyleRule::AddPropertiesToSet()
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: r_kato, Assigned: r_kato)
Details
Attachments
(1 file)
It seems there are no calls to these methods: * AnimValuesStyleRule::AddValue() * AnimValuesStyleRule::AddPropertiesToSet() https://dxr.mozilla.org/mozilla-central/rev/63be002b4a803df1122823841ef7633b7561d873/dom/animation/AnimValuesStyleRule.h Could you assign this clean-up work to me...?
Comment 1•8 years ago
|
||
Thanks! AnimValuesStyleRule::AddValue can not be removed for now since it will be used in bug 1245748. See https://hg.mozilla.org/try/rev/9282748dc327 I think AnimValuesStyleRule::AddPropertiesToSet could be still removed.
Assignee: nobody → foobar094
Assignee | ||
Comment 2•8 years ago
|
||
Thank you for quick responce! Then, I will make a patch for AddPropertiesToset :)
Assignee | ||
Updated•8 years ago
|
Summary: Remove unnecessary methods from AnimValuesStyleRule → Remove unnecessary method AnimValuesStyleRule::AddPropertiesToSet()
Updated•8 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42929/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42929/
Attachment #8735734 -
Flags: review?(hiikezoe)
Comment 4•8 years ago
|
||
Comment on attachment 8735734 [details] MozReview Request: Bug 1260353 - Remove unnecessary method AnimValuesStyleRule::AddPropertiesToSet() r?hiro https://reviewboard.mozilla.org/r/42929/#review39419 Yes, the function has not been used since https://hg.mozilla.org/mozilla-central/rev/4f7f1ba2036b#l4.71 Thanks!
Attachment #8735734 -
Flags: review?(hiikezoe) → review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b8d9e729d5b2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•