1260353 - Remove unnecessary method AnimValuesStyleRule::AddPropertiesToSet()

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Ryo Kato [:r_kato]]

It seems there are no calls to these methods:

  * AnimValuesStyleRule::AddValue()
  * AnimValuesStyleRule::AddPropertiesToSet()

https://dxr.mozilla.org/mozilla-central/rev/63be002b4a803df1122823841ef7633b7561d873/dom/animation/AnimValuesStyleRule.h

Could you assign this clean-up work to me...?

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Thanks!

AnimValuesStyleRule::AddValue can not be removed for now since it will be used in bug 1245748.
See https://hg.mozilla.org/try/rev/9282748dc327

I think AnimValuesStyleRule::AddPropertiesToSet could be still removed.

Comment 2

[Ryo Kato [:r_kato]]

Thank you for quick responce!

Then, I will make a patch for AddPropertiesToset :)

Comment 3

[Ryo Kato [:r_kato]]

Attachment: MozReview Request: Bug 1260353 - Remove unnecessary method AnimValuesStyleRule::AddPropertiesToSet() r?hiro

Review commit: https://reviewboard.mozilla.org/r/42929/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42929/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8735734 [details]
MozReview Request: Bug 1260353 - Remove unnecessary method AnimValuesStyleRule::AddPropertiesToSet() r?hiro

https://reviewboard.mozilla.org/r/42929/#review39419

Yes, the function has not been used since https://hg.mozilla.org/mozilla-central/rev/4f7f1ba2036b#l4.71
Thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8d9e729d5b2

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b8d9e729d5b2