1260391 - B2GOS: gfx/layers/ipc/ImageBridgeChild.cpp:230:29: error: no matching function for call to 'mozilla::layers::OpUseOverlaySource::OpUseOverlaySource(std::nullptr_t, mozilla::layers::PCompositableChild*, const OverlaySource&, const nsIntRect&)'

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1260391: Fix |CompositableOperation| on B2G

That's a build fix. I still have boot issues with b2g, which prevent me from testing.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8735788 [details] [diff] [review]
[01] Bug 1260391: Fix |CompositableOperation| on B2G

This fix crashes with https://pastebin.mozilla.org/8865428

Comment 3

[:gerard-majax]

Attachment: gdb stacktrace with build patch

The pastebin will expire tomorrow, let's keep this in bugzilla :)

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1260391: Fix |ImageBridgeChild::UseOverlaySource|

This is part 1 of the patch set. It should work.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

There's another issue in |ShadowLayerForwarder::RemoveTextureFromCompositableAsync|. This will probably require a larger change.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1260391: Transfer |CompositableOperation| in |AsyncChildMessageData|

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This patch set fixes the problem for me.

Comment 8

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8735857 [details] [diff] [review]
[02] Bug 1260391: Transfer |CompositableOperation| in |AsyncChildMessageData|

Review of attachment 8735857 [details] [diff] [review]:
-----------------------------------------------------------------

We can probably remove the "compositable" field from OpRemoveTexture after this.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1af60d28e014
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc37c0e8f135

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=dc37c0e8f135

Comment 11

[:gerard-majax]

Thomas, I think we could benefit from this being pushed to pine instead of having to wait the next mozilla-central merge there :)

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1af60d28e014
https://hg.mozilla.org/mozilla-central/rev/dc37c0e8f135

Comment 13

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Pushed to pine

https://hg.mozilla.org/projects/pine/rev/2e90bc5a3ed4
https://hg.mozilla.org/projects/pine/rev/711b8da55314