Closed
Bug 1260480
Opened 8 years ago
Closed 8 years ago
Remove mozNoMarginBoxes
Categories
(Core :: Printing: Output, defect)
Core
Printing: Output
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: tschneider, Assigned: tschneider)
Details
Attachments
(1 file, 1 obsolete file)
|
12.14 KB,
patch
|
Details | Diff | Splinter Review |
Now that we have a more standard conform way to control if margin boxes should be printed or not via CSS (by setting margin to 0 in a @page block), as implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1250674, I suggest removing the unofficial and redundant mozNoMarginBoxes.
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99996d88c7cc
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8735925 [details] [diff] [review] Remove mozNoMarginBoxes David, asking you to review since you also reviewed https://bugzilla.mozilla.org/show_bug.cgi?id=1250674, which aimed to replace this feature by a more standard conform one. I already talked to the PDF.js team, which originally implemented this feature, they don't have any concerns.
Attachment #8735925 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → tschneider
Comment on attachment 8735925 [details] [diff] [review] Remove mozNoMarginBoxes Please also remove persistMarginBoxSettings from: https://mxr.mozilla.org/mozilla-central/source/embedding/components/printingui/ipc/PPrintingTypes.ipdlh#71 r=dbaron with that Thanks for cleaing this up.
Attachment #8735925 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Addressed review comment.
Attachment #8735925 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3000c58d1d8e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•