Remove mozNoMarginBoxes

RESOLVED FIXED in Firefox 48

Status

()

Core
Printing: Output
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tobytailor, Assigned: tobytailor)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Now that we have a more standard conform way to control if margin boxes should be printed or not via CSS (by setting margin to 0 in a @page block), as implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1250674, I suggest removing the unofficial and redundant mozNoMarginBoxes.
(Assignee)

Comment 1

2 years ago
Created attachment 8735925 [details] [diff] [review]
Remove mozNoMarginBoxes
(Assignee)

Comment 2

2 years ago
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99996d88c7cc
(Assignee)

Comment 3

2 years ago
Comment on attachment 8735925 [details] [diff] [review]
Remove mozNoMarginBoxes

David, asking you to review since you also reviewed https://bugzilla.mozilla.org/show_bug.cgi?id=1250674, which aimed to replace this feature by a more standard conform one. I already talked to the PDF.js team, which originally implemented this feature, they don't have any concerns.
Attachment #8735925 - Flags: review?(dbaron)
(Assignee)

Updated

2 years ago
Assignee: nobody → tschneider
Comment on attachment 8735925 [details] [diff] [review]
Remove mozNoMarginBoxes

Please also remove persistMarginBoxSettings from:
https://mxr.mozilla.org/mozilla-central/source/embedding/components/printingui/ipc/PPrintingTypes.ipdlh#71

r=dbaron with that

Thanks for cleaing this up.
Attachment #8735925 - Flags: review?(dbaron) → review+
(Assignee)

Comment 5

2 years ago
Created attachment 8738618 [details] [diff] [review]
Remove mozNoMarginBoxes (v2)

Addressed review comment.
Attachment #8735925 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3000c58d1d8e
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3000c58d1d8e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.