1260480 - Remove mozNoMarginBoxes

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Tobias Schneider [:tobytailor]]

Now that we have a more standard conform way to control if margin boxes should be printed or not via CSS (by setting margin to 0 in a @page block), as implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1250674, I suggest removing the unofficial and redundant mozNoMarginBoxes.

Comment 1

[Tobias Schneider [:tobytailor]]

Attachment: Remove mozNoMarginBoxes

Comment 2

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99996d88c7cc

Comment 3

[Tobias Schneider [:tobytailor]]

Comment on attachment 8735925 [details] [diff] [review]
Remove mozNoMarginBoxes

David, asking you to review since you also reviewed https://bugzilla.mozilla.org/show_bug.cgi?id=1250674, which aimed to replace this feature by a more standard conform one. I already talked to the PDF.js team, which originally implemented this feature, they don't have any concerns.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 8735925 [details] [diff] [review]
Remove mozNoMarginBoxes

Please also remove persistMarginBoxSettings from:
https://mxr.mozilla.org/mozilla-central/source/embedding/components/printingui/ipc/PPrintingTypes.ipdlh#71

r=dbaron with that

Thanks for cleaing this up.

Comment 5

[Tobias Schneider [:tobytailor]]

Attachment: Remove mozNoMarginBoxes (v2)

Addressed review comment.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3000c58d1d8e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3000c58d1d8e