1260522 - Wrong OS description on 32bit Firefox under 64bit OS

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Alice0775 White]

Steps To　Reproduce:
1. Start 32bit Firefox under 64bit OS (Windows7 x64)
2. about:support

Actual Results:
OS 	Windows_NT 6.1 x86

Expected Results:
OS 	Windows_NT 6.1 x86-64

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

General attempt:
https://dxr.mozilla.org/mozilla-central/rev/fc15477ce628599519cb0055f52cc195d640dc94/addon-sdk/source/lib/sdk/system.js#124-126

For Windows, we could query the OS:
https://dxr.mozilla.org/mozilla-central/rev/fc15477ce628599519cb0055f52cc195d640dc94/addon-sdk/source/lib/sdk/system.js#124-126

Dave, how should this be done?

Comment 2

[Dave Townsend [:mossop]]

We probably just shouldn't include the Firefox architecture in the box for the OS: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutSupport.js#40

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d943acd40e6c&selectedJob=20112640

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: MozReview Request: Bug 1260522 - Don't try to show the OS architecture in about:support. r?adw

Review commit: https://reviewboard.mozilla.org/r/49551/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49551/

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 8747033 [details]
MozReview Request: Bug 1260522 - Don't try to show the OS architecture in about:support. r?adw

https://reviewboard.mozilla.org/r/49551/#review46565

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Pushed: https://hg.mozilla.org/integration/fx-team/rev/7e4ac3f24fa87986c044d9ee13c1cf557ea55d07

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e4ac3f24fa8

Comment 8

[Tanvir Rahman]

I have reproduced this bug with Nightly 48.0a1(2016-03-29) on Windows 10, 64 bit!

The Bug's fix is now verified on latest Beta 49.0b4

Build ID 	20160814184416
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0

[bugday-20160817]

Comment 9

[Carmen]

I managed to reproduce the issue using Firefox nightly 48.0a1(2016-03-29) on Windows 10 x64.
I verified the fix on latest Beta 49.0b7.

Build ID: 20160825132718
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0

[testday-20160826]