Phabricator will be unavailable due to database maintenance from 14:00 UTC until 18:00 UTC on Saturday, October 13, 2018.
Bugzilla will remain up during this time. All users have been logged out of Bugzilla
Bugzilla will remain up during this time. All users have been logged out of Bugzilla
obj[foo] += 5 calls ToPropertyKey on foo twice, against spec.
RESOLVED
FIXED
in Firefox 48
Status
()
People
(Reporter: efaust, Assigned: efaust)
Tracking
(Depends on: 1 bug)
Firefox Tracking Flags
(firefox48 fixed)
Details
Attachments
(1 attachment)
|
6.83 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
Created attachment 8736059 [details] [diff] [review] Fix This is the lamest thing ever. Just because everyone else does it, doesn't mean we have to, also. Clean up an open-coding of emitElemOperands along the way :).
Attachment #8736059 -
Flags: review?(jorendorff)
|
(Assignee) | |
Updated•3 years ago
|
||
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
|
||
Comment 1•3 years ago
|
||
Comment on attachment 8736059 [details] [diff] [review] Fix Review of attachment 8736059 [details] [diff] [review]: ----------------------------------------------------------------- Stealing so we can land this straight away.
Attachment #8736059 -
Flags: review?(jorendorff) → review+
|
||
Comment 3•3 years ago
|
||
Comment on attachment 8736059 [details] [diff] [review] Fix Review of attachment 8736059 [details] [diff] [review]: ----------------------------------------------------------------- "SelfAssign" is unobvious to me. Does that mean compound assignment? (The ES spec doesn't seem to have a name for += and friends; "compound" is the word the Java Language Spec uses.)
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cd2868983231 https://hg.mozilla.org/mozilla-central/rev/57e8e4c71ecf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•