1260664 - W3C Reflect referrerPolicy as a limited enumerated attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Thomas Nguyen (:tnguyen)]

Running W3C referrer-policy test from [1] and filtering fail cases, I found a case: /referrer-policy/generic/subresource-test/attr-referrer-invalid-value.html

Error message : assert_equals: expected \"\" but got \"not-valid-value\
It seems, invalid referrerpolicy should not be reflected.

referrerpolicy attribute draft specs is shown in [2], but seems there's no spec mention about that.

[1] https://github.com/w3c/web-platform-tests/tree/master/referrer-policy
[2] https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-delivery-referrer-attribute

Comment 1

[Thomas Nguyen (:tnguyen)]

Following [1] invalid referrerPolicy (not referrerpolicy) should be replaced as empty string.
[1] https://www.w3.org/TR/html5/infrastructure.html#limited-to-only-known-values.

Comment 2

[Thomas Nguyen (:tnguyen)]

Attachment: WIP patch

WIP patch: change referrerPolicy to "limited to only known values" and update test case

Comment 3

[Thomas Nguyen (:tnguyen)]

Attachment: Reflect referrerPolicy as a limited enumerated attribute and update tests case

Comment 4

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8742303 [details] [diff] [review]
Reflect referrerPolicy as a limited enumerated attribute and update tests case

Review of attachment 8742303 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. maybe file follow ups to fix link and valid values in the new test.

You'll need a dom peer to make the final review.

::: dom/html/test/test_bug1260664.html
@@ +24,5 @@
> +SimpleTest.waitForExplicitFinish();
> +SimpleTest.waitForFocus(runTests);
> +
> +function runTests() {
> +  var elements = [ "iframe", "img", "a", "area" ];

maybe add a comment with bug number for the link element

Comment 5

[Thomas Nguyen (:tnguyen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e9c1d1b1626

Comment 6

[Thomas Nguyen (:tnguyen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d0b5298dfeb

Comment 7

[Thomas Nguyen (:tnguyen)]

:), Try result 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=55f9fd61fde7&selectedJob=19796764

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/643063a2427b

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/643063a2427b