W3C Reflect referrerPolicy as a limited enumerated attribute

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tnguyen, Assigned: tnguyen)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Running W3C referrer-policy test from [1] and filtering fail cases, I found a case: /referrer-policy/generic/subresource-test/attr-referrer-invalid-value.html

Error message : assert_equals: expected \"\" but got \"not-valid-value\
It seems, invalid referrerpolicy should not be reflected.

referrerpolicy attribute draft specs is shown in [2], but seems there's no spec mention about that.

[1] https://github.com/w3c/web-platform-tests/tree/master/referrer-policy
[2] https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-delivery-referrer-attribute
(Assignee)

Comment 1

3 years ago
Following [1] invalid referrerPolicy (not referrerpolicy) should be replaced as empty string.
[1] https://www.w3.org/TR/html5/infrastructure.html#limited-to-only-known-values.
(Assignee)

Updated

3 years ago
Blocks: 1168540
(Assignee)

Comment 2

3 years ago
Created attachment 8739286 [details] [diff] [review]
WIP patch

WIP patch: change referrerPolicy to "limited to only known values" and update test case
Assignee: nobody → tnguyen
Whiteboard: btpp-active
(Assignee)

Updated

3 years ago
Summary: W3C Invalid referrerpolicy attribute value fails → W3C Reflect referrerPolicy as a limited enumerated attribute
(Assignee)

Comment 3

3 years ago
Created attachment 8742303 [details] [diff] [review]
Reflect referrerPolicy as a limited enumerated attribute and update tests case
Attachment #8739286 - Attachment is obsolete: true
Attachment #8742303 - Flags: review?(franziskuskiefer)
Comment on attachment 8742303 [details] [diff] [review]
Reflect referrerPolicy as a limited enumerated attribute and update tests case

Review of attachment 8742303 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. maybe file follow ups to fix link and valid values in the new test.

You'll need a dom peer to make the final review.

::: dom/html/test/test_bug1260664.html
@@ +24,5 @@
> +SimpleTest.waitForExplicitFinish();
> +SimpleTest.waitForFocus(runTests);
> +
> +function runTests() {
> +  var elements = [ "iframe", "img", "a", "area" ];

maybe add a comment with bug number for the link element
Attachment #8742303 - Flags: review?(franziskuskiefer) → review+
(Assignee)

Updated

3 years ago
Attachment #8742303 - Flags: review?(bugs)

Updated

3 years ago
Attachment #8742303 - Flags: review?(bugs) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/643063a2427b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.