Closed Bug 1260664 Opened 4 years ago Closed 3 years ago

W3C Reflect referrerPolicy as a limited enumerated attribute

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: tnguyen, Assigned: tnguyen)

References

(Blocks 1 open bug)

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 1 obsolete file)

Running W3C referrer-policy test from [1] and filtering fail cases, I found a case: /referrer-policy/generic/subresource-test/attr-referrer-invalid-value.html

Error message : assert_equals: expected \"\" but got \"not-valid-value\
It seems, invalid referrerpolicy should not be reflected.

referrerpolicy attribute draft specs is shown in [2], but seems there's no spec mention about that.

[1] https://github.com/w3c/web-platform-tests/tree/master/referrer-policy
[2] https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-delivery-referrer-attribute
Following [1] invalid referrerPolicy (not referrerpolicy) should be replaced as empty string.
[1] https://www.w3.org/TR/html5/infrastructure.html#limited-to-only-known-values.
Blocks: 1168540
Attached patch WIP patch (obsolete) — Splinter Review
WIP patch: change referrerPolicy to "limited to only known values" and update test case
Assignee: nobody → tnguyen
Whiteboard: btpp-active
Summary: W3C Invalid referrerpolicy attribute value fails → W3C Reflect referrerPolicy as a limited enumerated attribute
Attachment #8739286 - Attachment is obsolete: true
Attachment #8742303 - Flags: review?(franziskuskiefer)
Comment on attachment 8742303 [details] [diff] [review]
Reflect referrerPolicy as a limited enumerated attribute and update tests case

Review of attachment 8742303 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. maybe file follow ups to fix link and valid values in the new test.

You'll need a dom peer to make the final review.

::: dom/html/test/test_bug1260664.html
@@ +24,5 @@
> +SimpleTest.waitForExplicitFinish();
> +SimpleTest.waitForFocus(runTests);
> +
> +function runTests() {
> +  var elements = [ "iframe", "img", "a", "area" ];

maybe add a comment with bug number for the link element
Attachment #8742303 - Flags: review?(franziskuskiefer) → review+
Attachment #8742303 - Flags: review?(bugs)
Attachment #8742303 - Flags: review?(bugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/643063a2427b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.