Closed
Bug 1260713
Opened 8 years ago
Closed 8 years ago
RefCounted.h:106:50: error: no member named 'typeSize' in 'mozilla::KeyboardInfo' 0:22.21 uint32_t size = static_cast<const T*>(this)->typeSize();
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: gwagner, Assigned: chunmin)
References
Details
Attachments
(1 file)
3.63 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Patches in bug 1110030 don't compile when building mulet with debug enabled.
Reporter | ||
Comment 1•8 years ago
|
||
Chun-Min, can you take a look? We need to back out if this doesn't get fixed asap.
Reporter | ||
Updated•8 years ago
|
Summary: efCounted.h:106:50: error: no member named 'typeSize' in 'mozilla::KeyboardInfo' 0:22.21 uint32_t size = static_cast<const T*>(this)->typeSize(); → RefCounted.h:106:50: error: no member named 'typeSize' in 'mozilla::KeyboardInfo' 0:22.21 uint32_t size = static_cast<const T*>(this)->typeSize();
Assignee | ||
Comment 2•8 years ago
|
||
I think I need to add "MOZ_DECLARE_REFCOUNTED_TYPENAME(KeyboardInfo);"
Reporter | ||
Comment 3•8 years ago
|
||
I also see dom/inputmethod/HardwareKeyHandler.cpp:424:3: error: invalid argument type 'mozilla::WidgetKeyboardEvent' to unary expression 0:20.01 MOZ_ASSERT(aEvent, "No event provided"); and mozilla/RefCounted.h:105:53: error: no member named 'typeName' in 'mozilla::KeyboardInfo' 0:20.03 const char* type = static_cast<const T*>(this)->typeName();
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Gregor Wagner [:gwagner] from comment #3) > I also see dom/inputmethod/HardwareKeyHandler.cpp:424:3: error: invalid > argument type 'mozilla::WidgetKeyboardEvent' to unary expression > 0:20.01 MOZ_ASSERT(aEvent, "No event provided"); > > and mozilla/RefCounted.h:105:53: error: no member named 'typeName' in > 'mozilla::KeyboardInfo' > 0:20.03 const char* type = static_cast<const T*>(this)->typeName(); I think I can remove it because |aEvent| is not pointer. I will submit a patch after testing it. Should I submit patch here? or in bug 1110030?
Flags: needinfo?(anygregor)
Assignee | ||
Comment 6•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8736318 -
Flags: review?(anygregor)
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8736318 [details] [diff] [review] b1260713-fix.patch Smaug is probably a better reviewer.
Attachment #8736318 -
Flags: review?(anygregor) → review?(bugs)
Comment 8•8 years ago
|
||
Ok, our documentation for RefCounted is buggy. It doesn't say one must define MOZ_DECLARE_REFCOUNTED_TYPENAME.
Updated•8 years ago
|
Attachment #8736318 -
Flags: review?(bugs) → review+
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3c89bafeec3b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•