1260713 - RefCounted.h:106:50: error: no member named 'typeSize' in 'mozilla::KeyboardInfo' 0:22.21 uint32_t size = static_cast<const T*>(this)->typeSize();

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Gregor Wagner [:gwagner]]

Patches in bug 1110030 don't compile when building mulet with debug enabled.

Comment 1

[Gregor Wagner [:gwagner]]

Chun-Min, can you take a look? We need to back out if this doesn't get fixed asap.

Comment 2

[C.M.Chang[:chunmin]]

I think I need to add "MOZ_DECLARE_REFCOUNTED_TYPENAME(KeyboardInfo);"

Comment 3

[Gregor Wagner [:gwagner]]

I also see  dom/inputmethod/HardwareKeyHandler.cpp:424:3: error: invalid argument type 'mozilla::WidgetKeyboardEvent' to unary expression
 0:20.01   MOZ_ASSERT(aEvent, "No event provided");

and mozilla/RefCounted.h:105:53: error: no member named 'typeName' in 'mozilla::KeyboardInfo'
 0:20.03     const char* type = static_cast<const T*>(this)->typeName();

Comment 4

[C.M.Chang[:chunmin]]

(In reply to Gregor Wagner [:gwagner] from comment #3)
> I also see  dom/inputmethod/HardwareKeyHandler.cpp:424:3: error: invalid
> argument type 'mozilla::WidgetKeyboardEvent' to unary expression
>  0:20.01   MOZ_ASSERT(aEvent, "No event provided");
> 
> and mozilla/RefCounted.h:105:53: error: no member named 'typeName' in
> 'mozilla::KeyboardInfo'
>  0:20.03     const char* type = static_cast<const T*>(this)->typeName();

I think I can remove it because |aEvent| is not pointer.
I will submit a patch after testing it.
Should I submit patch here? or in bug 1110030?

Comment 5

[Gregor Wagner [:gwagner]]

Submit the patch here please.

Comment 6

[C.M.Chang[:chunmin]]

Attachment: b1260713-fix.patch

Comment 7

[Gregor Wagner [:gwagner]]

Comment on attachment 8736318 [details] [diff] [review]
b1260713-fix.patch

Smaug is probably a better reviewer.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Ok, our documentation for RefCounted is buggy. It doesn't say one must define MOZ_DECLARE_REFCOUNTED_TYPENAME.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c89bafeec3b

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3c89bafeec3b