Closed Bug 1260713 Opened 4 years ago Closed 4 years ago

RefCounted.h:106:50: error: no member named 'typeSize' in 'mozilla::KeyboardInfo' 0:22.21 uint32_t size = static_cast<const T*>(this)->typeSize();

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gwagner, Assigned: chunmin)

References

Details

Attachments

(1 file)

Patches in bug 1110030 don't compile when building mulet with debug enabled.
Chun-Min, can you take a look? We need to back out if this doesn't get fixed asap.
Assignee: nobody → cchang
Blocks: 1110030, 1245091
Summary: efCounted.h:106:50: error: no member named 'typeSize' in 'mozilla::KeyboardInfo' 0:22.21 uint32_t size = static_cast<const T*>(this)->typeSize(); → RefCounted.h:106:50: error: no member named 'typeSize' in 'mozilla::KeyboardInfo' 0:22.21 uint32_t size = static_cast<const T*>(this)->typeSize();
I think I need to add "MOZ_DECLARE_REFCOUNTED_TYPENAME(KeyboardInfo);"
I also see  dom/inputmethod/HardwareKeyHandler.cpp:424:3: error: invalid argument type 'mozilla::WidgetKeyboardEvent' to unary expression
 0:20.01   MOZ_ASSERT(aEvent, "No event provided");

and mozilla/RefCounted.h:105:53: error: no member named 'typeName' in 'mozilla::KeyboardInfo'
 0:20.03     const char* type = static_cast<const T*>(this)->typeName();
(In reply to Gregor Wagner [:gwagner] from comment #3)
> I also see  dom/inputmethod/HardwareKeyHandler.cpp:424:3: error: invalid
> argument type 'mozilla::WidgetKeyboardEvent' to unary expression
>  0:20.01   MOZ_ASSERT(aEvent, "No event provided");
> 
> and mozilla/RefCounted.h:105:53: error: no member named 'typeName' in
> 'mozilla::KeyboardInfo'
>  0:20.03     const char* type = static_cast<const T*>(this)->typeName();

I think I can remove it because |aEvent| is not pointer.
I will submit a patch after testing it.
Should I submit patch here? or in bug 1110030?
Flags: needinfo?(anygregor)
Submit the patch here please.
Flags: needinfo?(anygregor)
Attachment #8736318 - Flags: review?(anygregor)
Comment on attachment 8736318 [details] [diff] [review]
b1260713-fix.patch

Smaug is probably a better reviewer.
Attachment #8736318 - Flags: review?(anygregor) → review?(bugs)
Ok, our documentation for RefCounted is buggy. It doesn't say one must define MOZ_DECLARE_REFCOUNTED_TYPENAME.
Attachment #8736318 - Flags: review?(bugs) → review+
Keywords: checkin-needed
Blocks: 1260710
https://hg.mozilla.org/mozilla-central/rev/3c89bafeec3b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.