1260765 - Show login options on press, not long-press

Status: VERIFIED FIXED

(Firefox for iOS :: Login Management, defect, P3)

Description

[Ryan Feeley [:rfeeley]]

So that I can expose options more quickly, the options that appear after a long press on saved logins (Copy, Reveal and Open & Fill) should appear immediately (after a normal-length press).

Comment 1

[Maurya Talisetti]

There is no long-press behavior for Copy, Reveal and Open & Fill in version 8.0(1).

Is this bug still relevant Ryan?

Comment 2

[Ryan Feeley [:rfeeley]]

Yes, would love this one. There is no reason to hide this option under a long press. Should appear on tap (and long-press if users do that too).

Comment 3

[Maurya Talisetti]

Ryan, not sure if you missed this:

(from comment #1)
> There is no long-press behavior for Copy, Reveal and Open & Fill in version
> 8.0(1).

Hence, I was wondering if your suggestion was still relevant given that tap takes us into the login details. The options you are referring to are not shown at all in the current version. You could try running the latest build and see to get a better idea.

Comment 4

[Ryan Feeley [:rfeeley]]

I will take your word for it, but latest beta I have (7.3) still does it.

Comment 5

[:garvan]

Confirmed on master that there is no context menu on the Logins list view.
Not sure if 8.x branch could differ in this regard.

Comment 6

[:garvan]

Ryan are you referring to the Logins list view, or the detail view of an individual login?

Comment 7

[Ryan Feeley [:rfeeley]]

Individual login view: on website (copy, open & fill), username (copy) and password (copy, reveal). They should appear on press, not require a long press.

Next time I'll include a screenshot to reduce confusion.

Comment 8

[:garvan]

Attachment: Pull request

Comment 9

[:garvan]

https://github.com/mozilla-mobile/firefox-ios/commit/f7c64741929dd37993f83d54f5ed45eb27e84cba

Comment 10

[Simon Basca [:SimonB]]

Verifying as fix on master 35383ea5439.

Comment 11

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v8.x

Comment 12

[Catalin Suciu [:csuciu]]

Verified as fixed in build 8.0 (4811)