1260768 - showError() function is broken [Error: can't access lexical declaration 'window' before initialization]

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 4.9a2 (Build ID 20160330004109)

I tried to import an ics file that resulted in an import error. But instead of the import error dialog I got nothing. Error console shows:

Error: ReferenceError: can't access lexical declaration 'window' before initialization
Source File: chrome://calendar/content/calUtils.js
Line: 1008

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: use different variable name to avoid conflict with outer window object

Comment 2

[Stefan Sitter [:ssitter]]

Reported with Lightning 4.7b2 (Build ID 20160218191916) and Thunderbird 45.0 too.

Comment 3

[[:MakeMyDay]]

There is one more place in the calendar code where window is used as a variable name. Does that need to be renamed, too?

https://mxr.mozilla.org/comm-central/source/calendar/base/modules/calProviderUtils.jsm#432

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to MakeMyDay from comment #3)
I think it should be fine. In cal_promptOverwrite it just declares a local variable window.

Philipp, In my opinion we should consider porting back the fix, because as of now errors are not reported to the user but hidden in console due to this problem.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8736349 [details] [diff] [review]
use different variable name to avoid conflict with outer window object

Review of attachment 8736349 [details] [diff] [review]:
-----------------------------------------------------------------

How far did you want this backported? ESR45?

::: calendar/base/src/calUtils.js
@@ +1004,5 @@
>   *
>   * @param aMsg The message to be shown
>   */
>  function showError(aMsg) {
> +    let wnd = window || null;

I know it has been this way before, but it could actually show a `ReferenceError: window is not defined`, at least when I test it in xpcshell. You could use `let wnd = typeof "window" === undefined ? null : window`.

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/cbdfc91f5d59f351e818d534eb075ce1d262e2b9
Bug 1260768 - showError() function is broken [Error: can't access lexical declaration 'window' before initialization]. r=Fallen

Comment 7

[[:MakeMyDay]]

https://hg.mozilla.org/releases/comm-aurora/rev/06c3aadde9bf312e681fd0e12bb253075b204b5a
https://hg.mozilla.org/releases/comm-beta/rev/b00046532da51845a963f918c8cec1e410b2e21f

Comment 8

[[:MakeMyDay]]

https://hg.mozilla.org/releases/comm-esr45/rev/dfab8f086c880252c8c0cee5ed59b9a25e3b286a