Closed Bug 1260791 Opened 7 years ago Closed 7 years ago

Allow creating an alert manually

Categories

(Tree Management :: Perfherder, defect)

Product:
Tree Management
Component:
Perfherder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(2 files)

[treeherder] wlach:1260791 > mozilla:master
47 bytes, text/x-github-pull-request
jmaher
: review+
Details | Review
[treeherder] wlach:1260791-2 > mozilla:master
47 bytes, text/x-github-pull-request
Details | Review 
I thought we had an issue for this, but apparently we don't. In any case, Perfherder needs the ability to be able to create an alert manually, in case the automatic regression detection fails to notice the change. This happens occasionally.
Blocks: 1261969
Working on this, making good progress.
Assignee: nobody → wlachance
Comment on attachment 8758018 [details] [review]
[treeherder] wlach:1260791 > mozilla:master

This turned out to be a bit easier than expected. We'll probably need to refine some, but this prototype works well in initial testing.
Attachment #8758018 - Flags: review?(jmaher)
Comment on attachment 8758018 [details] [review]
[treeherder] wlach:1260791 > mozilla:master

thanks for using the defaults
Attachment #8758018 - Flags: review?(jmaher) → review+
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/11bb8a0a8a9fffeb2478b1fe4288e10cd2b0b3d9
Bug 1260791 - Refactor and improve performance alert unit tests

https://github.com/mozilla/treeherder/commit/772bcfa5a19783518f629f22786eaf790e316c51
Bug 1260791 - Don't close graph tooltip when clicking inside it

We need to be able to do that to allow manually creating alerts.

https://github.com/mozilla/treeherder/commit/988dcda5a8a6d8ebb2c95503e1754088bb9173c7
Bug 1260791 - In perf signature endpoint, identify signatures by id

https://github.com/mozilla/treeherder/commit/bede7c13907fe09fb66268b0c4ce9975995cc825
Bug 1260791 - Add API's for creating performance alerts + alert summaries

https://github.com/mozilla/treeherder/commit/3f84b3fe442b7ee3d99333520dc101cad00d7f51
Bug 1260791 - UI support for manually created performance alerts

https://github.com/mozilla/treeherder/commit/bc4319728740356e605230978b939808baabc713
Merge pull request #1541 from wlach/1260791

Bug 1260791 - Manually created alerts
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b071ba7a0d4133b0b8a283437ff246e77fdb5c7d
Bug 1260791 - Disable create alert UI if not logged in as sheriff

https://github.com/mozilla/treeherder/commit/85dedd344e40eefd3a59d77591bfa7474881859b
Merge pull request #1556 from wlach/1260791-2

Bug 1260791 - Disable create alert UI if not logged in as sheriff
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.