1260891 - Acquire and release the lock when destorying an `ExclusiveData<T>`'s protected value

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Even if there is not a traditional race between uses of the protected data and
the `ExclusiveData<T>`'s destruction, the thread running the destructor has no
guarantee that its cache is up to date with changes already made by other
threads. The new acquire and release surrounding the destructor ensures that the
destructor doesn't run on stale cache lines.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Acquire and release the lock when destorying an `ExclusiveData<T>`'s protected value

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecee6617df38

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/297e38fbff06

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/297e38fbff06

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/297e38fbff06