Closed
Bug 1260891
Opened 8 years ago
Closed 8 years ago
Acquire and release the lock when destorying an `ExclusiveData<T>`'s protected value
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
3.16 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Even if there is not a traditional race between uses of the protected data and the `ExclusiveData<T>`'s destruction, the thread running the destructor has no guarantee that its cache is up to date with changes already made by other threads. The new acquire and release surrounding the destructor ensures that the destructor doesn't run on stale cache lines.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8736482 -
Flags: review?(terrence)
Assignee | ||
Comment 2•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecee6617df38
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Updated•8 years ago
|
Attachment #8736482 -
Flags: review?(terrence) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder landing |
https://hg.mozilla.org/integration/mozilla-inbound/rev/297e38fbff06
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/297e38fbff06
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•