Closed Bug 1260891 Opened 4 years ago Closed 4 years ago

Acquire and release the lock when destorying an `ExclusiveData<T>`'s protected value

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

Even if there is not a traditional race between uses of the protected data and
the `ExclusiveData<T>`'s destruction, the thread running the destructor has no
guarantee that its cache is up to date with changes already made by other
threads. The new acquire and release surrounding the destructor ensures that the
destructor doesn't run on stale cache lines.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecee6617df38
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #8736482 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/297e38fbff06
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.