1260899 - Enter an intermediate unable-to-sync mode when server bookmarks transition from consistent to inconsistent

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

When we've never synced and the server is inconsistent, we refuse to do so, and we offer a read-only UI.

When we're syncing and the server is consistent, everything is editable.

There is a third scenario: we've made no (or minimal) changes, and new server data puts the buffer into an inconsistent state. Typically this will be due to a partial write or a missed change on a desktop.

We should respond to that change by entering another fallback state, disallowing deletions of non-mobile bookmarks, disallowing moves, and eventually showing affordances to explain what's going on.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1780

Figured I should probably attach this instead of having it live in Github. Sorry for the feedback flag!

Comment 2

[Richard Newman [:rnewman]]

I hope to get to this today. (Sorry for the Tofino-related delays!)

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8750788 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1780

Reflagging for feedback on adding editable checks and tests. I know you're busy but I wouldn't mind some feedback on the approach and questions I have about the unit tests. Thanks in advance!

Comment 4

[Stephan Leroux [:sleroux]]

master 5979d61c9ff72d00e4c18b85a4f805f9d86b36a4