Closed
Bug 1260933
Opened 8 years ago
Closed 8 years ago
For invalid easing values, print the invalid value
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: birtles, Assigned: daisuke)
Details
Attachments
(4 files)
Trying to debug bug 1260878 would be a lot easier if we actually printed the invalid easing. Daisuke, can you take this?
Reporter | ||
Comment 1•8 years ago
|
||
Oh, I should add, if, as a result of bug 1260878, we decide *not* to throw when we get an invalid easing, then we should still produce a console warning for this.
Assignee | ||
Comment 2•8 years ago
|
||
of course!
Assignee | ||
Comment 3•8 years ago
|
||
This is a screenshot with invalid easing value.
Assignee | ||
Comment 4•8 years ago
|
||
Also, I'll implement bug 1244643 too.
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43367/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43367/
Attachment #8736541 -
Flags: review?(bbirtles)
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8736541 [details] MozReview Request: Bug 1260933 - Part 1: For invalid easing values, print the invalid value. r=birtles https://reviewboard.mozilla.org/r/43367/#review39975 Thank you!
Attachment #8736541 -
Flags: review?(bbirtles) → review+
Assignee | ||
Comment 7•8 years ago
|
||
screenshot for invalid duration
Assignee | ||
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43381/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43381/
Attachment #8736541 -
Attachment description: MozReview Request: Bug 1260933 - Part 1: For invalid easing values, print the invalid value. r?birtles → MozReview Request: Bug 1260933 - Part 1: For invalid easing values, print the invalid value. r=birtles
Attachment #8736553 -
Flags: review?(bbirtles)
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8736541 [details] MozReview Request: Bug 1260933 - Part 1: For invalid easing values, print the invalid value. r=birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43367/diff/1-2/
Reporter | ||
Updated•8 years ago
|
Attachment #8736553 -
Flags: review?(bbirtles) → review+
Reporter | ||
Comment 10•8 years ago
|
||
Comment on attachment 8736553 [details] MozReview Request: Bug 1260933 - Part 2: For invalid duration values, print the invalid value. r=birtles https://reviewboard.mozilla.org/r/43381/#review39983
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8736541 [details] MozReview Request: Bug 1260933 - Part 1: For invalid easing values, print the invalid value. r=birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43367/diff/2-3/
Attachment #8736553 -
Attachment description: MozReview Request: Bug 1260933 - Part 2: For invalid duration values, print the invalid value. r?birtles → MozReview Request: Bug 1260933 - Part 2: For invalid duration values, print the invalid value. r=birtles
Assignee | ||
Comment 12•8 years ago
|
||
Comment on attachment 8736553 [details] MozReview Request: Bug 1260933 - Part 2: For invalid duration values, print the invalid value. r=birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43381/diff/1-2/
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 13•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ec5f90ead46 https://hg.mozilla.org/integration/mozilla-inbound/rev/2bcb11fae866
Keywords: checkin-needed
Comment 14•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1ec5f90ead46 https://hg.mozilla.org/mozilla-central/rev/2bcb11fae866
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•