1260935 - (origin_attribute_assertions) Need to add assertions in key locations to ensure origin attributes exist

Status: RESOLVED WONTFIX

(Core :: DOM: Security, defect)

Description

[Dave Huseby [:huseby]]

As part of the origin attributes project, we need to add assertions that origin attributes exist in key places in the code.

We need to add assertions here:
* Everywhere we call the origin attributes ::InherityFrom* functions.
* Whenever a channel is created and the loadInfo is initialized.
* Where the XulWindow object is created.  It needs to inherit the origin attributes from the UI if it is the top-level tab or from its parent XulWindow if it is an iframe.
* In the various hashing string creation functions.  The isolation hash strings should have origin attributes as inputs.

Comment 1

[Jonathan Hao (inactive) [:jhao]]

Hi Dave,

I'd like to take this bug, but I'm not sure what kind of assertions you want to add. Do you want to make sure those attributes aren't null? Or, do you want to ensure those origin attributes aren't default values?

Thank you.

Comment 2

[Dave Huseby [:huseby]]

Jonathan,

these assertions are just to ensure that the default set of origin attributes are defined and have values.  The default set is defined here: https://dxr.mozilla.org/mozilla-central/source/dom/webidl/ChromeUtils.webidl#77

--dave

Comment 3

[Jonathan Hao (inactive) [:jhao]]

After talking to Dave, the situation mentioned in Comment 0 is all in C++ where we can already be sure that we have all the origin attributes because C++ is statically-typed. Plus, we already have bugs to deal with origin attributes used in js.

So, I'm going to set this bug as WONTFIX.