Closed
Bug 1260950
Opened 9 years ago
Closed 9 years ago
mInitialSizeFound should be set to true when the initial size is found.
Categories
(Core :: Audio/Video: MediaStreamGraph, defect)
Core
Audio/Video: MediaStreamGraph
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: ctai, Assigned: ctai)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.31 KB,
patch
|
ctai
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/search?q=mInitialSizeFound&redirect=false&case=false => no place to set the bool member to true.
|
Assignee | |
Comment 1•9 years ago
|
||
A simple fix.
Attachment #8736545 -
Flags: review?(rjesup)
Attachment #8736545 -
Flags: review?(pehrsons)
|
||
Updated•9 years ago
|
Attachment #8736545 -
Flags: review?(rjesup) → review+
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8736545 [details] [diff] [review]
bug-1260950
Review of attachment 8736545 [details] [diff] [review]:
-----------------------------------------------------------------
Should break that loop when we find a valid size as well.
Attachment #8736545 -
Flags: review?(pehrsons) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Carry r+ from jesup and pehrsons.
Attachment #8736545 -
Attachment is obsolete: true
Attachment #8736628 -
Flags: review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•9 years ago
|
Summary: mInitialSizeFound should be set to true when the initial size id found. → mInitialSizeFound should be set to true when the initial size is found.
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
| bugherder landing | ||
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•