Closed
Bug 1260960
Opened 8 years ago
Closed 8 years ago
Check skiaGL is enabled before calling skiaGLTex()
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: pchang, Assigned: pchang)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
This bug is created from bug 1254447 comment 23. Should we avoid calling SkiaGLTex() if we don't have SkiaGL? Instead of this: GLuint skiaGLTex = SkiaGLTex(); if (mIsSkiaGL && skiaGLTex) { ... do this: GLuint skiaGLTex = 0; if (mIsSkiaGL) { skiaGLTex = SkiaGLTex(); } if (skiaGLTex) { ...
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → howareyou322
Whiteboard: [gfx-noted]
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43399/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43399/
Attachment #8736572 -
Flags: review?(snorp)
Comment on attachment 8736572 [details] MozReview Request: Bug 1260960 - Check skiaGL is enabled before calling skiaGLTex(), r?snorp https://reviewboard.mozilla.org/r/43399/#review40087
Attachment #8736572 -
Flags: review?(snorp) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a388e3337aff
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•