1260960 - Check skiaGL is enabled before calling skiaGLTex()

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Peter Chang[:pchang]]

This bug is created from bug 1254447 comment 23.


Should we avoid calling SkiaGLTex() if we don't have SkiaGL?  Instead of this:

GLuint skiaGLTex = SkiaGLTex();
if (mIsSkiaGL && skiaGLTex) {
  ...
  
do this:

GLuint skiaGLTex = 0;
if (mIsSkiaGL) {
  skiaGLTex = SkiaGLTex();
}
if (skiaGLTex) {
  ...

Comment 1

[Peter Chang[:pchang]]

Attachment: MozReview Request: Bug 1260960 - Check skiaGL is enabled before calling skiaGLTex(), r?snorp

Review commit: https://reviewboard.mozilla.org/r/43399/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43399/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8736572 [details]
MozReview Request: Bug 1260960 - Check skiaGL is enabled before calling skiaGLTex(), r?snorp

https://reviewboard.mozilla.org/r/43399/#review40087

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a388e3337aff

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a388e3337aff