Closed
Bug 1261007
Opened 8 years ago
Closed 8 years ago
Enable/fix testcases for MediaRecorder api on Fennec.
Categories
(Core :: Audio/Video: Recording, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bechen, Assigned: bechen)
References
Details
Attachments
(3 files)
See bug 1215115 comment 22. I want to enable [test_mediarecorder_record_canvas_captureStream.html] and [test_mediarecorder_record_changing_video_resolution.html] at all platforms. And fix test_mediarecorder_webm_support.html since we remove the vorbis encoder.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46045/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46045/
Attachment #8740854 -
Flags: review?(jolin)
Attachment #8740855 -
Flags: review?(giles)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46047/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46047/
Comment 3•8 years ago
|
||
Comment on attachment 8740855 [details] MozReview Request: Bug 1261007 - part2: fix test_mediarecorder_webm_support. r=rillian https://reviewboard.mozilla.org/r/46047/#review42601 ::: dom/media/test/test_mediarecorder_webm_support.html:16 (Diff revision 1) > ok(MediaRecorder.isTypeSupported('video/webm'), 'Should support video/webm'); > -ok(MediaRecorder.isTypeSupported('video/webm; codecs="vp8, vorbis"'), 'Should support video/webm + vp8/vorbis'); > +ok(!MediaRecorder.isTypeSupported('video/webm; codecs="vp8, vorbis"'), 'Should not support video/webm + vp8/vorbis'); > ok(!MediaRecorder.isTypeSupported('video/webm; codecs="vp9, vorbis"'), 'Should not support video/webm + vp9/vorbis'); > +ok(MediaRecorder.isTypeSupported('video/webm; codecs="vp8, opus"'), 'Should support video/webm + vp8/vorbis'); > +ok(!MediaRecorder.isTypeSupported('video/webm; codecs="vp9, opus"'), 'Should not support video/webm + vp9/vorbis'); > </script> Message is incorrect for the two new checks. It should be updated to reference opus instead of vorbis. For example: ``` ok(MediaRecorder.isTypeSupported('video/webm; codecs="vp8, opus"'), 'Should support video/webm + vp8/opus'); ok(!MediaRecorder.isTypeSupported('video/webm; codecs="vp9, opus"'), 'Should not support video/webm + vp9/opus'); ```
Attachment #8740855 -
Flags: review?(giles) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8740854 [details] MozReview Request: Bug 1261007: part1: Force to send video sample into encoder if we got the same video sample more than 1 seconds. Enable testcases. r=jolin https://reviewboard.mozilla.org/r/46045/#review42855 Now that TrackEncoder sends only unique images, the logic in OmxVideoTrackEncoder::GetEncodedTrack() seems unnecessary and it would be nice to be removed. ::: dom/media/test/mochitest.ini:705 (Diff revision 1) > tags=msg > [test_mediarecorder_record_audionode.html] > tags=msg > [test_mediarecorder_record_canvas_captureStream.html] > -skip-if = (android_version < '17' || toolkit == 'android') # Android/Gonk before SDK version 17 does not have the OMX Encoder API and Fennec does not support video recording > tags=msg This would break B2G but I guess we don't care anymore. ::: dom/media/test/mochitest.ini (Diff revision 1) > tags=msg > [test_mediarecorder_record_canvas_captureStream.html] > -skip-if = (android_version < '17' || toolkit == 'android') # Android/Gonk before SDK version 17 does not have the OMX Encoder API and Fennec does not support video recording > tags=msg > [test_mediarecorder_record_changing_video_resolution.html] > -skip-if = android_version < '17' # Android/Gonk before SDK version 17 does not have the OMX Encoder API. Ditto.
Attachment #8740854 -
Flags: review?(jolin)
Comment 5•8 years ago
|
||
Comment on attachment 8740854 [details] MozReview Request: Bug 1261007: part1: Force to send video sample into encoder if we got the same video sample more than 1 seconds. Enable testcases. r=jolin Forgot to click 'Ship it!'. :$
Attachment #8740854 -
Flags: review+
Assignee | ||
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46975/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46975/
Attachment #8742209 -
Flags: review?(jolin)
Attachment #8740854 -
Flags: review+
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8740855 [details] MozReview Request: Bug 1261007 - part2: fix test_mediarecorder_webm_support. r=rillian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46047/diff/1-2/
Comment 8•8 years ago
|
||
Comment on attachment 8740854 [details] MozReview Request: Bug 1261007: part1: Force to send video sample into encoder if we got the same video sample more than 1 seconds. Enable testcases. r=jolin https://reviewboard.mozilla.org/r/46045/#review43601
Attachment #8740854 -
Flags: review+
Comment 9•8 years ago
|
||
Comment on attachment 8742209 [details] MozReview Request: Bug 1261007 - part3: Remove the same/redundant code of checking the unique image. r=jolin https://reviewboard.mozilla.org/r/46975/#review43603 LGTM. Thanks!
Attachment #8742209 -
Flags: review?(jolin) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/482546446203 https://hg.mozilla.org/integration/mozilla-inbound/rev/5e3441e1a4c1 https://hg.mozilla.org/integration/mozilla-inbound/rev/a1da3524fc25
Keywords: checkin-needed
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/482546446203 https://hg.mozilla.org/mozilla-central/rev/5e3441e1a4c1 https://hg.mozilla.org/mozilla-central/rev/a1da3524fc25
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•