remove unused stuff [WAS: linux32, macosx-64 builds using MOZ_SYMBOLS_EXTRA_BUILDID=linux64]

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
9 months ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Details

Attachments

(3 attachments)

https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/scripts/builder/build-linux.sh#38
export MOZ_SYMBOLS_EXTRA_BUILDID=linux64

I have no idea what that does, but I'm guessing it's wrong.  Also pretty easy to fix.  I'll try to find a parallel in Buildbot-land.
I see this set in buildbot-configs:

> mozilla/config.py:                'MOZ_SYMBOLS_EXTRA_BUILDID': 'linux64',
> mozilla/config.py:                'MOZ_SYMBOLS_EXTRA_BUILDID': 'linux64-asan',
> mozilla/config.py:                'MOZ_SYMBOLS_EXTRA_BUILDID': 'linux64-tsan',
> mozilla/config.py:                'MOZ_SYMBOLS_EXTRA_BUILDID': 'linux64-asan-debug',
> mozilla/config.py:                'MOZ_SYMBOLS_EXTRA_BUILDID': 'linux64-st-an-debug',
> mozilla/config.py:                'MOZ_SYMBOLS_EXTRA_BUILDID': 'linux64',
> mozilla/config.py:                'MOZ_SYMBOLS_EXTRA_BUILDID': 'macosx64',
> mozilla/config.py:                'MOZ_SYMBOLS_EXTRA_BUILDID': 'win64',
> mozilla/config.py:BRANCHES['mozilla-central']['platforms']['android-x86']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-x86'
> mozilla/config.py:BRANCHES['mozilla-central']['platforms']['android-api-9']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-9'
> mozilla/config.py:BRANCHES['mozilla-central']['platforms']['android-api-15']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-15'
> mozilla/config.py:BRANCHES['mozilla-release']['platforms']['android-x86']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-x86'
> mozilla/config.py:BRANCHES['mozilla-release']['platforms']['android-api-9']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-9'
> mozilla/config.py:BRANCHES['mozilla-release']['platforms']['android-api-11']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-11'
> mozilla/config.py:BRANCHES['mozilla-release']['platforms']['android-api-15']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-15'
> mozilla/config.py:BRANCHES['mozilla-beta']['platforms']['android-x86']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-x86'
> mozilla/config.py:BRANCHES['mozilla-beta']['platforms']['android-api-9']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-9'
> mozilla/config.py:BRANCHES['mozilla-beta']['platforms']['android-api-11']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-11'
> mozilla/config.py:BRANCHES['mozilla-beta']['platforms']['android-api-15']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-15'
> mozilla/config.py:BRANCHES['mozilla-aurora']['platforms']['android-api-9']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-9'
> mozilla/config.py:BRANCHES['mozilla-aurora']['platforms']['android-api-11']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-11'
> mozilla/config.py:BRANCHES['mozilla-aurora']['platforms']['android-api-15']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-15'
> mozilla/config.py:BRANCHES['mozilla-aurora']['platforms']['android-x86']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-x86'
> mozilla/config.py:        BRANCHES[branch]['platforms']['linux']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = branch
> mozilla/config.py:        BRANCHES[branch]['platforms']['android-api-9']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-9-' + branch
> mozilla/config.py:        BRANCHES[branch]['platforms']['android-api-11']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-11-' + branch
> mozilla/config.py:        BRANCHES[branch]['platforms']['android-api-15']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-api-15-' + branch
> mozilla/config.py:        BRANCHES[branch]['platforms']['android-x86']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-x86-' + branch
> mozilla/config.py:        BRANCHES[branch]['platforms']['linux64']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'linux64-' + branch
> mozilla/config.py:        BRANCHES[branch]['platforms']['win32']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = branch
> mozilla/config.py:        BRANCHES[branch]['platforms']['macosx64']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'macosx64-' + branch

and some confusing special-casing in mozharness:

 951     def _query_moz_symbols_buildid(self):
 952         # this is a bit confusing but every platform that make
 953         # uploadsymbols may or may not include a
 954         # MOZ_SYMBOLS_EXTRA_BUILDID in the env and the value of this
 955         # varies.
 956         # logic goes:
 957         #   If it's the release branch, we only include it for
 958         # 64bit platforms and we use just the platform as value.
 959         #   If it's a project branch off m-c, we include only the branch
 960         # for the value on 32 bit platforms and we include both the
 961         # platform and branch for 64 bit platforms
 962         c = self.config
 963         moz_symbols_extra_buildid = ''
 964         if c.get('use_platform_in_symbols_extra_buildid'):
 965             moz_symbols_extra_buildid += self.stage_platform
 966         if c.get('use_branch_in_symbols_extra_buildid'):
 967             if moz_symbols_extra_buildid:
 968                 moz_symbols_extra_buildid += '-%s' % (self.branch,)
 969             else:
 970                 moz_symbols_extra_buildid = self.branch
 971         return moz_symbols_extra_buildid

1627     def build(self):
...
1632         if symbols_extra_buildid:
1633             env['MOZ_SYMBOLS_EXTRA_BUILDID'] = symbols_extra_buildid

so basically, this can come from any number of confusing places in buildbot-configs, but be overridden by mozharness in some other cases.  I admit that buildbot-configs triggers a flight response in my subconscious.

Ted, is there some rhyme or reason to the expected outcome here that I could try to replicate either by pepping up mozharness so that it just sets it correctly, or by setting it in each task description?  Or should I just pretend I never noticed this and back away slowly?
Flags: needinfo?(ted)
We can just remove this. It was added to avoid name collisions back when we were uploading files to NFS, but now everything goes through the Socorro symbol upload API which records the list of uploaded files anyway.
Flags: needinfo?(ted)
OK, so I can remove it from build-linux.sh for sure.  Should I also remove it from mozharness and buildbot-configs?
Yes, that's fine. It's not doing anything useful anywhere nowadays. Related: SYMBOL_SERVER_{HOST,SSH_KEY,USER_PATH} and POST_SYMBOL_UPLOAD_COMMAND are all vestigial as well!
Summary: linux32, macosx-64 builds using MOZ_SYMBOLS_EXTRA_BUILDID=linux64 → remove unused stuff [WAS: linux32, macosx-64 builds using MOZ_SYMBOLS_EXTRA_BUILDID=linux64]
Created attachment 8737201 [details]
MozReview Request: Bug 1261045: remove MOZ_SYMBOLS_EXTRA_BUILDID for andriod from beta/aurora/releases; r?jlund

This omits changes to mozilla-{release,beta,aurora} which can follow later.

Review commit: https://reviewboard.mozilla.org/r/43799/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43799/
Attachment #8737201 - Flags: review?(jlund)
Jordan, note that I didn't touch the release repos since there were TODO comments about future ESRs (46).  However, if you think it's safe to clean those out too, I'm all for it.  Alternately, if I've cleaned out too much, let me know.
Created attachment 8737238 [details]
MozReview Request: Bug 1261045: remove unused MOZ_SYMBOLS_EXTRA_BUILDID; r?ted.mielczarek

Review commit: https://reviewboard.mozilla.org/r/43833/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43833/
Attachment #8737238 - Flags: review?(ted)
Attachment #8737239 - Flags: review?(ted)
Created attachment 8737239 [details]
MozReview Request: Bug 1261045: remove unused SYMBOL_SERVER_*; r?ted.mielczarek

Review commit: https://reviewboard.mozilla.org/r/43835/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43835/

Updated

3 years ago
Attachment #8737201 - Flags: review?(jlund) → review+
Comment on attachment 8737201 [details]
MozReview Request: Bug 1261045: remove MOZ_SYMBOLS_EXTRA_BUILDID for andriod from beta/aurora/releases; r?jlund

https://reviewboard.mozilla.org/r/43799/#review40455

\o/
Comment on attachment 8737238 [details]
MozReview Request: Bug 1261045: remove unused MOZ_SYMBOLS_EXTRA_BUILDID; r?ted.mielczarek

https://reviewboard.mozilla.org/r/43833/#review40645

Whee!
Attachment #8737238 - Flags: review?(ted) → review+
Comment on attachment 8737239 [details]
MozReview Request: Bug 1261045: remove unused SYMBOL_SERVER_*; r?ted.mielczarek

https://reviewboard.mozilla.org/r/43835/#review40647

This was all obsoleted by the dependencies of bug 1071724, FYI. Specifically bug 1085557 switched the Firefox builders.
Attachment #8737239 - Flags: review?(ted) → review+
Comment on attachment 8737201 [details]
MozReview Request: Bug 1261045: remove MOZ_SYMBOLS_EXTRA_BUILDID for andriod from beta/aurora/releases; r?jlund

checked in
leaving open to try landing the same change for the release branches
Keywords: leave-open
Comment on attachment 8737201 [details]
MozReview Request: Bug 1261045: remove MOZ_SYMBOLS_EXTRA_BUILDID for andriod from beta/aurora/releases; r?jlund

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43799/diff/1-2/
Attachment #8737201 - Attachment description: MozReview Request: Bug 1261045: remove symobl-server configuration; r?jlund → MozReview Request: Bug 1261045: remove MOZ_SYMBOLS_EXTRA_BUILDID for andriod from beta/aurora/releases; r?jlund
Comment on attachment 8737201 [details]
MozReview Request: Bug 1261045: remove MOZ_SYMBOLS_EXTRA_BUILDID for andriod from beta/aurora/releases; r?jlund

mozreview didn't "get it" here despite my using a different bookmark and an different mozreview id.  Anyway, please have a look at this additional patch!
Attachment #8737201 - Flags: review+ → review?(jlund)
Comment on attachment 8737201 [details]
MozReview Request: Bug 1261045: remove MOZ_SYMBOLS_EXTRA_BUILDID for andriod from beta/aurora/releases; r?jlund

I _think_ it looks good. If I am seeing what I am supposed to, this is similar but you found some stray MOZ_SYMBOLS_EXTRA_BUILDID uses? or is this from a different branch?
Attachment #8737201 - Flags: review?(jlund) → review+
It's the same branch, but these apply to mozilla-{aurora,beta,release}, and I wasn't sure that the code changes to no longer require this information had already ridden the trains out that far.  So yes, pretty similar, just less confident it's right.
Well, the server those variables refer to has shuffled off this mortal coil, so I can say with great confidence that those variables are not doing anything useful.
Thanks all :)
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Depends on: 1263402
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.