Closed Bug 1261101 Opened 5 years ago Closed 5 years ago
Add full update snippet contents to the update results dictionary
58 bytes, text/x-review-board-request
In case of failures in update tests related to busted update snippets it would be great to have all the details listed in the log or even better in the update results dictionary as printed at the end of the test. The URL of the update snippet is getting added here: https://dxr.mozilla.org/mozilla-central/source/testing/puppeteer/firefox/firefox_puppeteer/api/software_update.py#229 > 'url_aus': self.get_update_url(True), So we could use urllib or similar to actually retrieve the content of that remote file.
Re-thinking that I feel it would be too much content inside the update results dictionary and lines won't be that readable. I would suggest we output the content via the info logger.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Review commit: https://reviewboard.mozilla.org/r/62122/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62122/
Attachment #8767705 - Flags: review?(mjzffr)
Ok, I reverted my opinion from above and it should be better to add it to the update result dictionary. With that we can store the whole dict as json file on disk and upload it to taskcluster.
Attachment #8767705 - Flags: review?(mjzffr) → review+
Comment on attachment 8767705 [details] Bug 1261101 - Add full update snippet contents to the update results dictionary. https://reviewboard.mozilla.org/r/62122/#review59212
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/a4abd7b926c7 Add full update snippet contents to the update results dictionary. r=maja_zf
Would be great to get this test only change onto mozilla-aurora. It will help us a lot with investigation of test failures of update tests. Please make sure that the patch on bug 1282080 lands first on mozilla-aurora. Thanks.
You need to log in before you can comment on or make changes to this bug.