Closed Bug 1261129 Opened 3 years ago Closed 3 years ago

benchmarking code added ~35K of non-const data

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox45 --- unaffected
firefox46 --- unaffected
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: froydnj, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1230265 added a large, non-const static array representing a small webm file.  This data isn't shareable between processes, and is responsible for a noticeable jump in Fennec's libxul size.  Making it const is trivial; do we even need to enable this code for Fennec?
Blocks: 1230265
Anthony: when we uplift bug 1230265 to Aurora 47, we will want this non-const data fix.
Flags: needinfo?(ajones)
Flags: needinfo?(ajones)
We can probably remove this in Fennec as many android phone now have hardware decoder.

I will open a bug to ensure that VP9 is always enabled on platforms with vp9 hardware decoding.
Depends on: 1261273
Comment on attachment 8737042 [details]
MozReview Request: Bug 1261129: Make VP9 sample data const. r?kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/43679/#review41217
Attachment #8737042 - Flags: review?(ajones) → review+
https://hg.mozilla.org/mozilla-central/rev/05ce1f2670ae
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8737042 [details]
MozReview Request: Bug 1261129: Make VP9 sample data const. r?kentuckyfriedtakahe

Approval Request Comment
[Feature/regressing bug #]: 1261129
[User impact if declined]: blocking bug 1263839 uplift
[Describe test coverage new/current, TreeHerder]: in central for a while, and there's nothing to test really
[Risks and why]: none, just making the code const
[String/UUID change made/needed]: none
Attachment #8737042 - Flags: approval-mozilla-aurora?
Blocks: 1263839
Comment on attachment 8737042 [details]
MozReview Request: Bug 1261129: Make VP9 sample data const. r?kentuckyfriedtakahe

Recent issue due to VP9 benchmarking fix uplifted a few weeks back, this has baked in Nightly for a bit, Aurora47+
Attachment #8737042 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.