Closed
Bug 1261138
Opened 8 years ago
Closed 8 years ago
Cannot set socket timeout in marionette client
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox47 fixed, firefox48 fixed)
RESOLVED
FIXED
mozilla48
People
(Reporter: jgraham, Unassigned)
Details
Attachments
(1 file)
For a couple of reasons, including an artifically limited range of values, and the transport clobbering the timeout value.
Reporter | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43563/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43563/
Attachment #8736868 -
Flags: review?(ato)
Comment 2•8 years ago
|
||
Comment on attachment 8736868 [details] MozReview Request: Bug 1261138 - Allow marionette to have any socket timeout, including None indicating no timeout, r=ato https://reviewboard.mozilla.org/r/43563/#review40145 ::: testing/marionette/client/marionette_driver/transport.py:233 (Diff revision 1) > # Unset self.sock so that the next attempt to send will cause > # another connection attempt. > self.sock = None > raise > > - self.sock.settimeout(2.0) > + with SocketTimeout(self.sock, 2.0): Good catch and clever solution.
Attachment #8736868 -
Flags: review?(ato) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3ea44d60cb3f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 5•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/f5bf1f129e87
status-firefox47:
--- → fixed
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•