1261138 - Cannot set socket timeout in marionette client

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[James Graham [:jgraham]]

For a couple of reasons, including an artifically limited range of values, and the transport clobbering the timeout value.

Comment 1

[James Graham [:jgraham]]

Attachment: MozReview Request: Bug 1261138 - Allow marionette to have any socket timeout, including None indicating no timeout, r=ato

Review commit: https://reviewboard.mozilla.org/r/43563/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43563/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8736868 [details]
MozReview Request: Bug 1261138 - Allow marionette to have any socket timeout, including None indicating no timeout, r=ato

https://reviewboard.mozilla.org/r/43563/#review40145

::: testing/marionette/client/marionette_driver/transport.py:233
(Diff revision 1)
>              # Unset self.sock so that the next attempt to send will cause
>              # another connection attempt.
>              self.sock = None
>              raise
>  
> -        self.sock.settimeout(2.0)
> +        with SocketTimeout(self.sock, 2.0):

Good catch and clever solution.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ea44d60cb3f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ea44d60cb3f

Comment 5

[David Burns :automatedtester]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f5bf1f129e87