1261213 - make test_sts_privatebrowsing_perwindowpb.html work under e10s

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

The mochitest-chrome test test_sts_privatebrowsing_perwindowpb.html doesn't work in e10s-mode. I briefly tried to modify it so it would, but I didn't get very far. I could use some help from someone who knows what they're doing in this area.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

jst, would you be able to suggest someone who could help out here? Thanks.

Comment 2

[Johnny Stenback (:jst)]

Blake and Felipe should be good starting points for help in how to proceed here.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1261213-make-test_sts_privatebrowsing_perwindowp.patch

Removed the direct content window accesses by using ContentTask and other helpers. Test behavior should not have changed, they succeed in e10s and non-e10s mode on my machine.

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8738097 [details] [diff] [review]
0001-Bug-1261213-make-test_sts_privatebrowsing_perwindowp.patch

Review of attachment 8738097 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1505798c1593

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Pushed a small follow-up to keep eslint happy:

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b1175e474a7

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1505798c1593
https://hg.mozilla.org/mozilla-central/rev/5b1175e474a7