1261220 - Synced Tabs not appearing as awesomebar results

Status: RESOLVED INVALID

(Firefox :: Sync, defect, P3)

Description

[Ryan Feeley [:rfeeley]]

Attachment: Awesomebar.png

STR
Have two devices connected to Sync (at least one being desktop)
Open a webpage you've never visited on one device
Do a manual sync on both browsers
On the other Firefox (desktop) type in part of the URL

ER
Awesomebar result should appear as designed

AR
Result shows as a generic synced history item, but not as a synced tab

Comment 1

[Chris Karlof [:ckarlof]]

IIUC, one deficiency with the current implementation is that the remote synced tabs show up at the bottom of your results, and if you have enough results, the synced tab result might be getting truncated.

I can get some of my remote tabs to appear in results, but for queries that have a lot of Awesomebar results, I can reproduce your issue.

Comment 2

[Chris Karlof [:ckarlof]]

I feel next steps here are to get a simple reproducible test case.

Comment 3

[Ryan Feeley [:rfeeley]]

Attachment: Screenshot 2016-04-01 15.53.42.png

I can do it every time.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

(In reply to Chris Karlof [:ckarlof] from comment #2)
> I feel next steps here are to get a simple reproducible test case.

I think what you are seeing is how it is currently supposed to work, so a test case probably isn't that helpful. I expect we just need to convince the relevant people that how it is supposed to work should change (but I fear that will not be easy - I can understand why people would suggest that local results *should* trump remote tabs) It might be easier to make a case that we should *always* show this entry, even if it is as the bottom of the list (ie, local matches would still "win" in terms of ordering, but we would just add a new entry instead of bumping the remote tab(s) off)

(In reply to Ryan Feeley [:rfeeley] from comment #3)
> I can do it every time.

Note that the awesomebar makes no attempt to perform a sync - so you need to make sure Sync has run at-least once before testing this. Another total long-shot is that a pref "services.sync.syncedTabs.showRemoteIcons" disables showing them - so maybe make sure that's not set in your profile.

Comment 5

[Michelle Funches - QA]

Attachment: Sync_DesktopGalaxyS5.png

1) Device 1: Sign into Sync (Samsung S5)
2) Access a new site (http://www.applebees.com)
3) Access Menu Setting and update the Sync
4) Access the Desktop and select Menu and refresh the sync
5) Access desktop URL bar and type apple
Observe: Awesome bar drop down list displays Firefox on SM-G800F (screenshot attached)

Version 	45.0.1
Build ID 	20160315153207
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
 45.0.1 Firefox for Android Release: March 16, 2016
Please let me know if you have any additional request/testing for this bug

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Michelle Funches - QA from comment #5)
> Created attachment 8737950 [details]
> Sync_DesktopGalaxyS5.png

Thanks, but that is STR for the feature working normally. Comment 3 is a screenshot of the feature *not* working, and this is really what we need the STR for here.

Comment 7

[Chris Karlof [:ckarlof]]

Next steps are to investigate.

Comment 8

[Ryan Feeley [:rfeeley]]

It appears the problem is limited to my work MacBook. Is that even possible?

Comment 9

[Mark Hammond [:markh] [:mhammond]]

(In reply to Ryan Feeley [:rfeeley] from comment #8)
> It appears the problem is limited to my work MacBook. Is that even possible?

Not really. The screenshot here isn't clear, but I suspect the entry is just being bumped off the bottom of the list - eg, see also bug 1263806 where I note that one more URL with "voy" in the gibberish part of it would probably have prevented it working there too.

Can you attach a screenshot of the *entire* URLBar and dropdown in cases where it is missing, and also on the MacBook where it *is* working?

Comment 10

[Ryan Feeley [:rfeeley]]

It's the same issue as the screenshot here: https://bugzilla.mozilla.org/attachment.cgi?id=8736971

It's the only result in the list, and it shows only as History, not as a Synced Tab.

Comment 11

[Mark Hammond [:markh] [:mhammond]]

Edouard, do you think you might be able to help Ryan here - the timezones will make it much easier. There's not very good diagnostics in the awesomebar code, so I suspect you probably want to first check Ryan can reproduce this problem on Nightly, then make a try build for him with some dumps or similar. Thanks!

Comment 12

[Ryan Feeley [:rfeeley]]

Attachment: byrrh.png

Here's an exampe of a tab I opened this weekend, not showing up in the awesomebar, even after I've synced and can see it appearing in the synced tabs menu.

Comment 13

[Edouard Oger [:eoger]]

Gave a try build for rfeeley on IRC, clearing NI

Comment 14

[Alex Davis [:adavis]]

Changed to P3 until rfeeley: confirms that this is still an issue.

Comment 15

[Ryan Feeley [:rfeeley]]

I can't reliably reproduce this. Just tried and was able to reproduce it, but after about a minute, the Synced Tab result showed up. Would love automated testing to check for this.