resizer is not drawn in themes using GtkThemingEngine render_handle

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

()

Attachments

(1 attachment)

Reproduces with Raleigh of 3.4.2 and Adwaita of 3.16.7.
Assignee: nobody → karlt
Blocks: 1223198
gtk_render_handle() in GTK+-3.4.2 at least uses the background color to draw
resizers.  background-color defaults to transparent and is not inherited.
GtkTextView typically has its own background color, and I think we should be using GtkTextView for textfield-multiline.

If we start seeing the wrong background color being drawn, then maybe it could
be better not to draw resizers in some situations.  The cursor appearance
changes to indicate resize is available anyway.  However, this patch works for
Adwaita and Raleigh at least.  Tested with Raleigh and Ambiance with 3.4.2 and
Raleigh and Adwaita of 3.16.7.
Attachment #8737059 - Flags: review?(andrew) → review+
Comment on attachment 8737059 [details]
MozReview Request: bug 1261277 use GtkTextView to get an appropriate color for resizers r?acomminos

https://reviewboard.mozilla.org/r/43693/#review40265

Looks good!

::: widget/gtk/gtk3drawing.cpp:720
(Diff revision 1)
> +    if (gTextViewWidget)
> +        return;
> +
> +    gTextViewWidget = gtk_text_view_new();
> +    ensure_scrolled_window_widget();
> +    gtk_container_add(GTK_CONTAINER(gScrolledWindowWidget), gTextViewWidget);;

Double semicolon at the end of the line here.
Comment on attachment 8737059 [details]
MozReview Request: bug 1261277 use GtkTextView to get an appropriate color for resizers r?acomminos

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43693/diff/1-2/

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f7eef7358c99
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.