Closed
Bug 1261285
Opened 9 years ago
Closed 9 years ago
old-configure partial log on failure is incomplete
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Because closing the handler is not enough (it eventually reopens
itself), the dumping of config.log overwrites the file, and confuses
the process of reading it to dump it in the first place, showing
incomplete logs. The intent from the start was that nothing would be
logged in the FileHandler, so on top of closing it, actively remove it.
Review commit: https://reviewboard.mozilla.org/r/43727/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43727/
Attachment #8737082 -
Flags: review?(ted)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8737082 [details]
MozReview Request: Bug 1261285 - Properly remove the config.log logging handler before running old-configure. r?ted
https://reviewboard.mozilla.org/r/43727/#review40649
Attachment #8737082 -
Flags: review?(ted) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•