1261340 - |RawDBusConnection| doesn't build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Changes to |ScopedPtr| broke |RawDBusConnection|. It should be converted to |UniquePtr|.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1261340: Use |UniqueFreePtr| in |RawDBusConnection|

Just a fix to get DBus building again.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8737165 [details] [diff] [review]
[01] Bug 1261340: Use |UniqueFreePtr| in |RawDBusConnection|

Review of attachment 8737165 [details] [diff] [review]:
-----------------------------------------------------------------

I did not see the patch actually use |UniqueFreePtr|, did I miss anything?

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Oh sorry, my description of the patch is completely wrong. :(

I will submit a new patch. I saw you started reviewing bug 1246931. Landing this patch set should also fix the problem.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1261340: Don't refer to |ScopedFreePtrTraits| in |RawDBusConnection|

Shawn, sorry again for the messed-up patch description. This is the same patch, but with the correct note.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks Shawn!

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=506fd0f2d9d3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/506fd0f2d9d3