Closed
Bug 1261340
Opened 9 years ago
Closed 9 years ago
|RawDBusConnection| doesn't build
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.74 KB,
patch
|
shawnjohnjr
:
review+
|
Details | Diff | Splinter Review |
Changes to |ScopedPtr| broke |RawDBusConnection|. It should be converted to |UniquePtr|.
|
Assignee | |
Comment 1•9 years ago
|
||
Just a fix to get DBus building again.
Attachment #8737165 -
Flags: review?(shuang)
Comment on attachment 8737165 [details] [diff] [review]
[01] Bug 1261340: Use |UniqueFreePtr| in |RawDBusConnection|
Review of attachment 8737165 [details] [diff] [review]:
-----------------------------------------------------------------
I did not see the patch actually use |UniqueFreePtr|, did I miss anything?
Attachment #8737165 -
Flags: review?(shuang)
Flags: needinfo?(tzimmermann)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Oh sorry, my description of the patch is completely wrong. :(
I will submit a new patch. I saw you started reviewing bug 1246931. Landing this patch set should also fix the problem.
Flags: needinfo?(tzimmermann)
|
|
Assignee | |
Updated•9 years ago
|
Summary: Convert |RawDBusConnection| to |UniquePtr| → Fix |RawDBusConnection| build issue
|
|
Assignee | |
Updated•9 years ago
|
Summary: Fix |RawDBusConnection| build issue → |RawDBusConnection| doesn't build
|
|
Assignee | |
Comment 4•9 years ago
|
||
Shawn, sorry again for the messed-up patch description. This is the same patch, but with the correct note.
Attachment #8737165 -
Attachment is obsolete: true
Attachment #8738996 -
Flags: review?(shuang)
Attachment #8738996 -
Flags: review?(shuang) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•