Closed Bug 1261472 Opened 4 years ago Closed 3 years ago

cors/response-headers.htm tests multi-value headers incorrectly

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: deckycoss, Unassigned)

Details

Attachments

(1 file)

The cors/response-headers.htm test has two failures (http://mxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/cors/response-headers.htm.ini). The expected result for getResponseHeader("x-custom-header") is "test", but the actual result is "test, test". In this case, the actual result is the correct result. This is because "X-Custom-Header" is defined twice in cors-headers.asis: http://mxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/cors/resources/cors-headers.asis

The test needs to be updated so that the expected results reflect the actual, currently correct results.

For reference, see https://tools.ietf.org/html/rfc7230#section-3.2.2 ("A recipient MAY combine multiple header fields...")
Comment on attachment 8755524 [details]
MozReview Request: Bug 1261472: fix incorrect test assertion in 'getResponse: don't expose x-nonexposed' and 'Combined testing of cors response headers'; r?ehsan

https://reviewboard.mozilla.org/r/54652/#review51564

Looks great, thanks!
Attachment #8755524 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/88b6b3ebf75d
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.