1261472 - cors/response-headers.htm tests multi-value headers incorrectly

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Decky Coss (:deckycoss)]

The cors/response-headers.htm test has two failures (http://mxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/cors/response-headers.htm.ini). The expected result for getResponseHeader("x-custom-header") is "test", but the actual result is "test, test". In this case, the actual result is the correct result. This is because "X-Custom-Header" is defined twice in cors-headers.asis: http://mxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/cors/resources/cors-headers.asis

The test needs to be updated so that the expected results reflect the actual, currently correct results.

For reference, see https://tools.ietf.org/html/rfc7230#section-3.2.2 ("A recipient MAY combine multiple header fields...")

Comment 1

[Decky Coss (:deckycoss)]

Attachment: MozReview Request: Bug 1261472: fix incorrect test assertion in 'getResponse: don't expose x-nonexposed' and 'Combined testing of cors response headers'; r?ehsan

Review commit: https://reviewboard.mozilla.org/r/54652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54652/

Comment 2

[(no longer active)]

Comment on attachment 8755524 [details]
MozReview Request: Bug 1261472: fix incorrect test assertion in 'getResponse: don't expose x-nonexposed' and 'Combined testing of cors response headers'; r?ehsan

https://reviewboard.mozilla.org/r/54652/#review51564

Looks great, thanks!

Comment 3

[Decky Coss (:deckycoss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a534faa1bcf2

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88b6b3ebf75d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88b6b3ebf75d