Closed Bug 1261503 Opened 5 years ago Closed 5 years ago

Update win32 rust to target i586-pc-windows-msvc

Categories

(Firefox Build System :: General, defect)

x86
Windows
defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file, 1 obsolete file)

Upstream rust now has nightly builds of the standard library for the i586-pc-windows-msvc target. This should be a more permanent fix for the sse2 instruction issues.
Comment on attachment 8737382 [details] [diff] [review]
Update win32 tooltool rust to 1.9 nightly + i586 target

>diff --git a/browser/config/tooltool-manifests/win32/releng.manifest b/browser/config/tooltool-manifests/win32/releng.manifest
>+"filename": "rustc-i586-pc-windows-msvc_20160401.tar.bz2",

Actually, this should probably just be "rustc.tar.bz2", since tooltool uses the basename of the package to determine how to remove the previous package. In this case, the package contains a "rustc" directory, so by naming the file rustc.tar.bz2, tooltool will try to rmtree('rustc') and remove the old package. As-is, tooltool will try to rmtree('rustc-i586-pc-windows-msvc_20160401'), which doesn't exist. The contents are still unpacked into the rustc directory, overwriting anything there. This would only present a problem if you remove a file in a new package, and if its presence would cause problems somehow.
Attachment #8737382 - Flags: review?(mshal) → review+
> Actually, this should probably just be "rustc.tar.bz2"

Ok changed. Carrying forward r=mshal

Unfortunate though. It's really nice to have a distinguishing filename so one has some idea where the build comes from.
Attachment #8737382 - Attachment is obsolete: true
Attachment #8737857 - Flags: review+
(In reply to Ralph Giles (:rillian) from comment #3)
> Created attachment 8737857 [details] [diff] [review]
> Update win32 tooltool rust to 1.9 nightly + i586 target v2
> 
> > Actually, this should probably just be "rustc.tar.bz2"
> 
> Ok changed. Carrying forward r=mshal
> 
> Unfortunate though. It's really nice to have a distinguishing filename so
> one has some idea where the build comes from.

That's why we have "version" in gcc and clang stanzas.
https://hg.mozilla.org/mozilla-central/rev/8c19cce84a1b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.