1261567 - mozbuild for bundled libevent is missing an include directory

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Charles Collicutt]

Attachment: libeventcommon-compat.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160321181141

Steps to reproduce:

Attempt to build Firefox on a Linux machine without sys/queue.h


Actual results:

.../mozilla-central/obj-firefox-x86_64-pc-linux-gnu/dist/system_wrappers/sys/queue.h:3:28: fatal error: sys/queue.h: No such file or directory


Expected results:

libevent comes with its own sys/queue.h file in the compat directory, in case the system does not provide its own (as in this case). This should have been included.

However, libeventcommon.mozbuild does not include the compat directory in the list of include directories.

The attached patch fixes this.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Comment on attachment 8737484 [details] [diff] [review]
libeventcommon-compat.patch

Maybe Bill could review this?

You also need to format the patch properly. There's some directions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Comment 2

[Charles Collicutt]

Attachment: Patch to add compat dir to libevent include path

An attempt to reformat the patch as required by Mozilla.

Comment 3

[Charles Collicutt]

Thank you - please could you push this to the try server?

Comment 4

[Andrew McCreight (out of office until 8/21) [:mccr8]]

I did a try run here:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=680b65a5acb6
If it comes back green, I'll deal with getting it landed. Thanks for the patch.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a645a9f6e22

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a645a9f6e22