Closed Bug 1261567 Opened 4 years ago Closed 4 years ago
mozbuild for bundled libevent is missing an include directory
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Build ID: 20160321181141 Steps to reproduce: Attempt to build Firefox on a Linux machine without sys/queue.h Actual results: .../mozilla-central/obj-firefox-x86_64-pc-linux-gnu/dist/system_wrappers/sys/queue.h:3:28: fatal error: sys/queue.h: No such file or directory Expected results: libevent comes with its own sys/queue.h file in the compat directory, in case the system does not provide its own (as in this case). This should have been included. However, libeventcommon.mozbuild does not include the compat directory in the list of include directories. The attached patch fixes this.
Comment on attachment 8737484 [details] [diff] [review] libeventcommon-compat.patch Maybe Bill could review this? You also need to format the patch properly. There's some directions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
An attempt to reformat the patch as required by Mozilla.
Attachment #8739259 - Flags: review?(wmccloskey) → review+
Thank you - please could you push this to the try server?
4 years ago
Assignee: nobody → charles
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
I did a try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=680b65a5acb6 If it comes back green, I'll deal with getting it landed. Thanks for the patch.
You need to log in before you can comment on or make changes to this bug.