Closed Bug 1261567 Opened 4 years ago Closed 4 years ago

mozbuild for bundled libevent is missing an include directory

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: charles, Assigned: charles)

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 1 obsolete file)

Attached patch libeventcommon-compat.patch (obsolete) — Splinter Review
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160321181141

Steps to reproduce:

Attempt to build Firefox on a Linux machine without sys/queue.h


Actual results:

.../mozilla-central/obj-firefox-x86_64-pc-linux-gnu/dist/system_wrappers/sys/queue.h:3:28: fatal error: sys/queue.h: No such file or directory


Expected results:

libevent comes with its own sys/queue.h file in the compat directory, in case the system does not provide its own (as in this case). This should have been included.

However, libeventcommon.mozbuild does not include the compat directory in the list of include directories.

The attached patch fixes this.
Attachment #8737484 - Attachment is patch: true
Attachment #8737484 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 8737484 [details] [diff] [review]
libeventcommon-compat.patch

Maybe Bill could review this?

You also need to format the patch properly. There's some directions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
Attachment #8737484 - Flags: review?(wmccloskey)
An attempt to reformat the patch as required by Mozilla.
Attachment #8737484 - Attachment is obsolete: true
Attachment #8737484 - Flags: review?(wmccloskey)
Attachment #8739259 - Flags: review?(wmccloskey)
Attachment #8739259 - Flags: review?(wmccloskey) → review+
Thank you - please could you push this to the try server?
Assignee: nobody → charles
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
I did a try run here:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=680b65a5acb6
If it comes back green, I'll deal with getting it landed. Thanks for the patch.
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/4a645a9f6e22
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.