1261574 - [e10s] Content process crashed tab text is misleading

Status: NEW

(Firefox :: General, defect)

Description

[Dirkjan Ochtman (:djc)]

With a content process crash, the title on the page (I guess this is about:tabcrash) is "This tab has crashed". However, the effect seems to be that *all* tabs have to reload, so this wording is misleading.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey phlsa, got any thoughts on this?

Comment 2

[arni2033]

(In reply to Dirkjan Ochtman (:djc) from comment #0)
> the effect seems to be that *all* tabs have to reload
It is not true in both single-multi-process and multi-multi-proces modes, right? Do you agree?

Comment 3

[Jim Mathies [:jimm]]

dolske, wondering what we should do with this. Seems like polish. I'm not inclined to block e10s rollout on something like this.

Comment 4

[Barbara Bermes [:barbara] - NI please!]

djc, can you post a screenshot please.

I'll try to reach out to UX but if I can't get anybody to comment, I'm happy to take this on/make this call. I agree this should not block.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Here's a screenshot of the tab crashed page:

http://i.imgur.com/OwAW2OV.png

In this case, the background "Reddit" tab also crashed, but it has been put in the "unrestored" background state, which means that the content will reload as soon as the tab is selected.

Comment 6

[Barbara Bermes [:barbara] - NI please!]

I don't see this being something we need UX at this point.

I also don't think there is a good option right now to change the wording especially since we treat the other crashed tabs differently (reload automatically once selected).

The only thing I would suggest is to remove the "...or restore all your crashed tabs" if the "Restore all tabs" button doesn't show. That to me is misleading.

Comment 7

[Justin Dolske [:Dolske]]

Improving the text is probably worthwhile, but I don't really have a good suggestion. I think most users are just going to see whatever's on this page as "Something went wrong. [Fix it]" page, so nuance around what exactly is happening and how it's explained isn't going to have much practical effect.

Comment 8

[Jim Mathies [:jimm]]

Looks like we do have inaccurate text here - 

"Now for the good news: You can just close this tab, restore it or restore all your crashed tabs."

"restore all your crashed tabs" needs to go right? We removed this option.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

(In reply to Jim Mathies [:jimm] from comment #8)
> "restore all your crashed tabs" needs to go right? We removed this option.

Almost - we still show the option if more than one about:tabcrashed is open.

Comment 10

[:Felipe Gomes (needinfo for replies!)]

mconley: if there's gonna be string work done here, can we also include bug 1273630 together in the conversation?

Comment 11

[Mike Conley (:mconley) (:⚙️)]

(In reply to :Felipe Gomes (needinfo me!) from comment #10)
> mconley: if there's gonna be string work done here, can we also include bug
> 1273630 together in the conversation?

Yeah, I think that's a fine idea.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

A proposal:

If only one tab has crashed, the about:tabcrashed page shows:


"Bad news first: This tab has crashed

Now for the good news: You can just close this tab or restore it."


if multiple tabs just crashed, we'll show:

"Bad news first: Some tabs have crashed

Now for the good news: Your crashed background tabs will restore when you select them. As for this tab, you can close it, or restore it."


If we've got multiple about:tabcrashed pages showing (multiple crashes in a row without restores in between, or multiple windows), we follow the same rules as above, but show the "Restore All Tabs" button, which will restore all of the about:tabcrashed pages.

matej might be able to word-smith that more, but I'm not sure if he's around lately... I'll needinfo just in case. What do you think, matej?

Comment 13

[Matej Novak [:matej]]

There are a couple of minor stylistic things I would clean up, but now that Michelle has started, I'd like her to have a look at this and see if she has any broader thoughts about the language here.

Comment 14

[mheubusch]

Hi! Michelle here. I think you are asking for three versions of the message, and here is what I recommend (although I am not sure that I am understanding the functionality correctly - in the third case (does closing close just 1 tab or all tabs in the window?) so I give options 3a and 3b.  (I'll respond separately in the other bug with some questions I have there.  

1. First, the bad news: Your tab crashed
Now, the good news. You can restore this tab, or simply close it. 

2. First, the bad news: Your tabs crashed
Now, the good news. You can restore this tab - or simply close it - and the other crashed tabs will restore when you select them. 

3a. First, the bad news: Your tabs crashed
Now, the good news. You can restore all tabs, restore just this tab, or simply close it.

3b. First, the bad news: Your tabs crashed
Now, the good news. You can restore this tab, restore all tabs, or close all tabs.

Comment 15

[Matej Novak [:matej]]

Hi Michelle. I think these options look good, but I think it reads a little more smoothly without some of the commas. I also changed one "the" to "your." Have a look and let me know if you're OK with these edits:

1. First the bad news: Your tab crashed
Now the good news. You can restore this tab or simply close it. 

2. First the bad news: Your tabs crashed
Now the good news. You can restore this tab — or simply close it — and your other crashed tabs will restore when you select them.

3a. First the bad news: Your tabs crashed
Now the good news. You can restore all tabs, restore just this tab or simply close it.

3b. First the bad news: Your tabs crashed
Now the good news. You can restore this tab, restore all tabs or close all tabs.

Comment 16

[Jim Mathies [:jimm]]

If the fx ux team would like to prioritize this they can. The e10s won't track this.

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Waiting for final thumbs up on matej's strings from Michelle (comment 15).

Comment 18

[mheubusch]

Sorry - didn't realize you were waiting on me.  Yes, please use the edits Matej provided.