1261632 - Assert that we're not sending OnStopRequest more than once

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Timothy Nikkel (:tnikkel)]

+++ This bug was initially created as a clone of Bug #1136969 +++

See bug 1137032, comment 12.

Comment 1

[Michal Novotny [:michal]]

Dragana, could you please make OnStopRequest variant of what you have done in bug 1136969?

Comment 2

[Dragana Damjanovic [:dragana]]

Taking it.

Comment 3

[Dragana Damjanovic [:dragana]]

Attachment: bug_1261632_v1.patch

Comment 4

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db4472dd2c3b

Comment 5

[Michal Novotny [:michal]]

Comment on attachment 8738205 [details] [diff] [review]
bug_1261632_v1.patch

Review of attachment 8738205 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/HttpBaseChannel.h
@@ +490,5 @@
>    uint32_t mCorsMode;
>    uint32_t mRedirectMode;
>    uint32_t mFetchCacheMode;
>  
> +  // This parameters are used to ensure that we do not call OnStartRequest and

This -> These

Comment 6

[Dragana Damjanovic [:dragana]]

Attachment: bug_1261632_v1.patch

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/946e39f5d97d

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/946e39f5d97d