Closed Bug 1261632 Opened 8 years ago Closed 8 years ago

Assert that we're not sending OnStopRequest more than once

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: tnikkel, Assigned: dragana)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1136969 +++

See bug 1137032, comment 12.
Dragana, could you please make OnStopRequest variant of what you have done in bug 1136969?
Flags: needinfo?(dd.mozilla)
Taking it.
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(dd.mozilla)
Attached patch bug_1261632_v1.patch (obsolete) — Splinter Review
Attachment #8738205 - Flags: review?(michal.novotny)
Comment on attachment 8738205 [details] [diff] [review]
bug_1261632_v1.patch

Review of attachment 8738205 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/HttpBaseChannel.h
@@ +490,5 @@
>    uint32_t mCorsMode;
>    uint32_t mRedirectMode;
>    uint32_t mFetchCacheMode;
>  
> +  // This parameters are used to ensure that we do not call OnStartRequest and

This -> These
Attachment #8738205 - Flags: review?(michal.novotny) → review+
Attachment #8738205 - Attachment is obsolete: true
Attachment #8738502 - Flags: review+
Keywords: checkin-needed
Whiteboard: [necko-active]
https://hg.mozilla.org/mozilla-central/rev/946e39f5d97d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.