1261655 - Scratchpad can not save while change ua

Status: RESOLVED DUPLICATE of bug 1254025

(DevTools Graveyard :: Scratchpad, defect, P2)

Description

[Alice0775 White]

This is a regression since Firefox44.0.

Reproducible: Always

Steps to reproduce:
1. Open about:config
1. Set devtools.chrome.enabled = true
2. change ua to Android / Chrome. i.e,
   general.useragent.override = ozilla/5.0 (Linux; Android 5.1.1; HWT31 Build/Federer) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.93 Safari/537.36

3. Open Scratchpad and change Environment to browser
4. File > Save As > Save
5. Attempt to close the Scratchpad

Actual Results:
It happens nothing saved.
Cannot close.

Expected Results:
Save and Close normaly

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=21015383ac41061eab25d01b546cd2713ff17b36&tochange=2bfe5435c1d1e2784af3b225d629a210023daecd

Regressed by: Bug 1132557

Comment 2

[FateRover]

when change ua  scratchpad cannot save code，and when open two scratchpad from F12 , and then close the main window of firefox，the two scratchpad will not close，and click the x button will do nothing

Comment 3

[Julian Descottes [:jdescottes]]

Temporarily assigning P2, might be P1.

Comment 4

[Brian Grinstead [:bgrins]]

Thanks for filing.  I'm not sure why the codemirror update triggered this problem.

I can confirm the issue, although it's only tied to the general.useragent.override pref and doesn't require switching to Browser Environemnt:

Here's what I see in the browser console:

  TypeError: cm.getInputField(...).controllers is undefined editor.js:434:7

Comment 5

[Brian Grinstead [:bgrins]]

Then when trying to close the window, it doesn't close and I see this:

TypeError: cm is undefined editor.js:962:5
Editor.prototype.isClean() editor.js:962
Scratchpad.dirty() scratchpad.js:313
SP_promptSave() scratchpad.js:1853
SP_close() scratchpad.js:1913
SP_onClose() scratchpad.js:1899
bound SP_onClose() self-hosted
editor.js

Comment 6

[FateRover]

seems that latest nightly have fixed it？

Comment 7

[Julian Descottes [:jdescottes]]

Thanks for the update FateRover.
Looking at comment 4, this must have been fixed by Bug 1254025 (we now force CM to use a textarea, regardless of the UserAgent).

Closing as duplicate, feel free to reopen if needed!

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Duplicate fixed, doesn't match esr criteria