1261827 - Text inputs for editing left and right padding/border/margin in the box-model tab are too big

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Patrick Brosset <:pbro>]

Attachment: Capture.PNG

STR:
- Use nightly (I built the fx-team branch today, not sure if this happens in nightly, but it sure doesn't in aurora).
- Open the inspector, switch the box-model tab
- Click on the left padding number for instance.

The input field is huge.

Comment 1

[Julian Descottes [:jdescottes]]

Regression due to Bug 1143742.

The inplace editor copies styles in 2 scenarios:
- from the replaced element to the input
- from the input to the measurement element

In order to support a multiline editor, the line-height is now part of the copied styles. However this style should only be copied when transferring styles from the input to the measurement element.

Comment 2

[Julian Descottes [:jdescottes]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4b88c4acc0b

In the meantime will try to come up with a test for this.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: MozReview Request: Bug 1261827 - inplace-editor: copyTextStyles should not copy line-height property;r=pbro

Only text styles should be copied between the replaced element and the input.
Other styles are still copied between the input and the measurement element.

Review commit: https://reviewboard.mozilla.org/r/44117/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44117/

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8737810 [details]
MozReview Request: Bug 1261827 - inplace-editor: copyTextStyles should not copy line-height property;r=pbro

https://reviewboard.mozilla.org/r/44117/#review40703

Looks good to me.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8649e83a43b9

Comment 6

[Julian Descottes [:jdescottes]]

Try was green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da39f126fcd5

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8649e83a43b9