Closed Bug 1262008 Opened 4 years ago Closed 4 years ago

Add WebGL feature status and failure causes to telemetry ping

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed
relnote-firefox --- -

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

(Keywords: feature, Whiteboard: [gfx-noted])

Attachments

(1 file)

Right now we just have raw WebGL histogram data in telemetry.

I'd like to include the feature state from the first time we try to initialize it. Perhaps something close to the compositor feature.

Ideally we can extend both to explain why the feature fails if it does. If it fails because of a blocklist we should include the ID of the rule. If it fails because of a code failure we should include an error ID that can map back to the call site.
Blocks: 1262011
Depends on: 1263249
Keywords: feature
Whiteboard: [gfx-noted]
Comment on attachment 8747285 [details]
MozReview Request: Bug 1262008 - Add WebGL failure causes to telemetry ping. r=dvander

https://reviewboard.mozilla.org/r/49809/#review46547
Attachment #8747285 - Flags: review?(dvander) → review+
Comment on attachment 8747285 [details]
MozReview Request: Bug 1262008 - Add WebGL failure causes to telemetry ping. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49809/diff/1-2/
Flags: needinfo?(bgirard)
Follow-up: Can you update the schema in nsIGfxInfo.idl to include failureId? (And note that status is optional - though when we move OpenGL/WebGL to gfxConfig it should be re-included.)
Untested branch for collecting this data on the dashboard: https://github.com/dvander/moz-gfx-telemetry/tree/webgl-fail-stats

2-3 days after this hits nightly we should be able to test.
Comment on attachment 8747285 [details]
MozReview Request: Bug 1262008 - Add WebGL failure causes to telemetry ping. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49809/diff/2-3/
Assignee: nobody → bgirard
Flags: needinfo?(bgirard)
Ahh oops. I put failureId inside the wrong feature object. I'll fix this when I touch this next.
https://hg.mozilla.org/mozilla-central/rev/d5687f5a5c67
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Hey Benoit, is manual QA required for this feature?
Flags: qe-verify?
Flags: needinfo?(bgirard)
No, we will be looking at the data ourselves to verify.
Flags: needinfo?(bgirard)
(In reply to Benoit Girard (:BenWa) from comment #11)
> No, we will be looking at the data ourselves to verify.

Thank you for following up on this, setting the qe flag accordingly.
Flags: qe-verify? → qe-verify-
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: WebGL status and failure causes are added to the telemetry data.
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
I don't think we need to release note this telemetry data add unless they affect the user in some way.
Cool.  I wasn't sure if we "announce" when we collect more/different data.  And, no, it doesn't effect the user.
You need to log in before you can comment on or make changes to this bug.