1262008 - Add WebGL feature status and failure causes to telemetry ping

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Girard (:BenWa)]

Right now we just have raw WebGL histogram data in telemetry.

I'd like to include the feature state from the first time we try to initialize it. Perhaps something close to the compositor feature.

Ideally we can extend both to explain why the feature fails if it does. If it fails because of a blocklist we should include the ID of the rule. If it fails because of a code failure we should include an error ID that can map back to the call site.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: Bug 1262008 - Add WebGL failure causes to telemetry ping. r=dvander

Review commit: https://reviewboard.mozilla.org/r/49809/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49809/

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8747285 [details]
MozReview Request: Bug 1262008 - Add WebGL failure causes to telemetry ping. r=dvander

https://reviewboard.mozilla.org/r/49809/#review46547

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8747285 [details]
MozReview Request: Bug 1262008 - Add WebGL failure causes to telemetry ping. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49809/diff/1-2/

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Follow-up: Can you update the schema in nsIGfxInfo.idl to include failureId? (And note that status is optional - though when we move OpenGL/WebGL to gfxConfig it should be re-included.)

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Untested branch for collecting this data on the dashboard: https://github.com/dvander/moz-gfx-telemetry/tree/webgl-fail-stats

2-3 days after this hits nightly we should be able to test.

Comment 6

[Benoit Girard (:BenWa)]

Comment on attachment 8747285 [details]
MozReview Request: Bug 1262008 - Add WebGL failure causes to telemetry ping. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49809/diff/2-3/

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5687f5a5c67

Comment 8

[Benoit Girard (:BenWa)]

Ahh oops. I put failureId inside the wrong feature object. I'll fix this when I touch this next.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5687f5a5c67

Comment 10

[Andrei Vaida [:avaida]]

Hey Benoit, is manual QA required for this feature?

Comment 11

[Benoit Girard (:BenWa)]

No, we will be looking at the data ourselves to verify.

Comment 12

[Andrei Vaida [:avaida]]

(In reply to Benoit Girard (:BenWa) from comment #11)
> No, we will be looking at the data ourselves to verify.

Thank you for following up on this, setting the qe flag accordingly.

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: WebGL status and failure causes are added to the telemetry data.
[Links (documentation, blog post, etc)]:

Comment 14

[Marcia Knous [:marcia]]

I don't think we need to release note this telemetry data add unless they affect the user in some way.

Comment 15

[Milan Sreckovic [:milan] (needinfo for best results)]

Cool.  I wasn't sure if we "announce" when we collect more/different data.  And, no, it doesn't effect the user.