126202 - Never use the Windows directory selection common dialog for saving multiple files

Status: NEW

(Firefox :: File Handling, enhancement)

Description

[Brian 'netdragon' Bober]

This is for any part of Mozilla that uses the directory selection common dialog.
For instance, Mailnews "Save All". I am not sure whether this is also in the
Mozilla Browser and assume it is part of the Mozilla File Handling code,
therefore, I put it into the Browser because I can't have it for multiple products.

The Windows directory selection box doesn't allow you to create new directories,
therefore it is not a good idea to use it for saving multiple files. It is
always nice to be able to add a new directory.

Comment 1

[Boris Zbarsky [:bzbarsky]]

What do you suggest we use?

Comment 2

[Brian 'netdragon' Bober]

Attachment: Picture of the offending dialog box

This is a picture of the offending dialog box.

Comment 3

[Brian 'netdragon' Bober]

If this dialog has a flag to allow you to create a new folder, then use it.
Otherwise, we should try to use the common one and somehow flag it to accept
directories only. I have seen the offending dialog box with the ability to make
new directories. I haven't looked into this fully, though (Don't have time right
now).

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://codeguru.earthweb.com/mfc/comments/2204.shtml has some information that
may be relevant...

Comment 5

[Brian 'netdragon' Bober]

Attachment: The correct way.

Somehow, IE's FTP window does it right.

Comment 6

[Boris Zbarsky [:bzbarsky]]

confirming rfe

Comment 7

[timeless]

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/platform/shell/reference/functions/shbrowseforfolder.asp
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/platform/shell/reference/structures/browseinfo.asp

BIF_USENEWUI

Comment 8

[:deanis74]

BIF_USENEWUI is available in version 5.0 of (I think) Shell32.dll .  Will 
versions below 5 (eg. 4.71) fail gracefully if the flag is passed in?

Comment 9

[:deanis74]

I'm pretty sure it would.  We should put the BIF_USENEWUI flag in and see if
there's any fallout.  Does anyone really have common controls less than 5.0
these days, though?