Closed Bug 1262057 Opened 4 years ago Closed 4 years ago

building busted due to using the wrong path for gcc

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
Thunderbird 48.0
Tracking Status
firefox48 --- fixed

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file, 5 obsolete files)

Current Linux* in c-c is busted due to :

checking for full perl installation... yes
checking for doxygen... not found
checking for tar... /bin/gtar
checking for unzip... /usr/bin/unzip
checking for xargs... /usr/bin/xargs
checking for zip... /usr/bin/zip
checking for rpmbuild... /usr/bin/rpmbuild
Refreshing /builds/slave/c-cen-t-lnx/build/mozilla/old-configure with /usr/bin/autoconf-2.13
creating cache ./config.cache
checking host system type... i686-pc-linux-gnu
checking target system type... i686-pc-linux-gnu
checking build system type... i686-pc-linux-gnu
checking for objcopy... /builds/slave/c-cen-t-lnx/build/gcc/bin/objcopy
checking for gcc... /builds/slave/c-cen-t-lnx/build/mozilla/gcc/bin/gcc -m32 -march=pentiumpro
checking whether the C compiler (/builds/slave/c-cen-t-lnx/build/mozilla/gcc/bin/gcc -m32 -march=pentiumpro -gdwarf-2 -L/builds/slave/c-cen-t-lnx/build/gtk3/usr/local/lib ) works... no
configure: error: installation or configuration problem: C compiler cannot create executables.
DEBUG: This file contains any messages produced by compilers while
DEBUG: running configure, to aid debugging if configure makes a mistake.
DEBUG: 

It's using build/mozilla/gcc/bin/gcc which is wrong.  It should be using 
build/gcc/bin/gcc.
Attached patch [mozconfigs] proposed patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8738079 - Flags: review?(bugspam.Callek)
Attachment #8738079 - Attachment is obsolete: true
Attachment #8738079 - Flags: review?(bugspam.Callek)
Product: SeaMonkey → MailNews Core
Attachment #8738368 - Flags: review?(mh+mozilla)
Attached patch [c-c] sync mozconfig.linux (obsolete) — Splinter Review
Attachment #8738369 - Flags: review?(Pidgeot18)
The remaining part of bug 1254987 I suppose.
I think it helps to have the right patch attached.
Attachment #8738368 - Attachment is obsolete: true
Attachment #8738368 - Flags: review?(mh+mozilla)
Attachment #8738460 - Flags: review?(mh+mozilla)
Hey Edmund, thanks for looking into it. Very much appreciated!
Comment on attachment 8738460 [details] [diff] [review]
[m-c] copy TOOLTOOL_DIR to mozconfig.linux (v2)

Review of attachment 8738460 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this might be a workaround until bug 1259382 lands!

::: build/unix/mozconfig.linux
@@ +20,4 @@
>  
>    # We want to make sure we use binutils and other binaries in the tooltool
>    # package.
>    mk_add_options PATH="$topsrcdir/gcc/bin:$PATH"

Don't you need to change this line as well?
Attachment #8738460 - Attachment is obsolete: true
Attachment #8738460 - Flags: review?(mh+mozilla)
Attachment #8738573 - Flags: review?(mh+mozilla)
Attached patch [c-c] sync mozconfig.linux (v2) (obsolete) — Splinter Review
Attachment #8738369 - Attachment is obsolete: true
Attachment #8738369 - Flags: review?(Pidgeot18)
Attachment #8738574 - Flags: review?(Pidgeot18)
Attachment #8738573 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
Attachment #8738573 - Attachment description: [m-c] copy TOOLTOOL_DIR to mozconfig.linux (v3) → [m-i] copy TOOLTOOL_DIR to mozconfig.linux (v3)
Blocks: 1254987
Given the try run in comment 9, I'm not sure this will actually fix Linux on c-c, but let's hope for the best!
(In reply to aleth [:aleth] from comment #13)
> Given the try run in comment 9, I'm not sure this will actually fix Linux on
> c-c, but let's hope for the best!

the try run on c-c was due to some 'badness' |make buildsymbols| and
not the compile step.  The bustage is mainly (from what :glandium suggests)
some confusion in which python is used.
https://hg.mozilla.org/mozilla-central/rev/0e40e61c0522
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
https://hg.mozilla.org/comm-central/rev/46cf4e453709bf7a045a895a9e5cefaa23f537cd
Keep build/ in sync: Bug 1262057 - Find gcc using TOOLTOOL_DIR. rs=bustage-fix CLOSED TREE
Attachment #8738574 - Attachment is obsolete: true
Attachment #8738574 - Flags: review?(Pidgeot18)
(In reply to Edmund Wong (:ewong) from comment #14)
> (In reply to aleth [:aleth] from comment #13)
> > Given the try run in comment 9, I'm not sure this will actually fix Linux on
> > c-c, but let's hope for the best!
> 
> the try run on c-c was due to some 'badness' |make buildsymbols| and
> not the compile step.  The bustage is mainly (from what :glandium suggests)
> some confusion in which python is used.

Right, I just meant I'm not sure we'll get a green build on treeherder ;)

Thanks!
(In reply to aleth [:aleth] from comment #17)
> (In reply to Edmund Wong (:ewong) from comment #14)
> > (In reply to aleth [:aleth] from comment #13)
> > > Given the try run in comment 9, I'm not sure this will actually fix Linux on
> > > c-c, but let's hope for the best!
> > 
> > the try run on c-c was due to some 'badness' |make buildsymbols| and
> > not the compile step.  The bustage is mainly (from what :glandium suggests)
> > some confusion in which python is used.
> 
> Right, I just meant I'm not sure we'll get a green build on treeherder ;)
> 
> Thanks!

The green build will most probably require some finess with the buildbotcustom
code.
You need to log in before you can comment on or make changes to this bug.