1262057 - building busted due to using the wrong path for gcc

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

Current Linux* in c-c is busted due to :

checking for full perl installation... yes
checking for doxygen... not found
checking for tar... /bin/gtar
checking for unzip... /usr/bin/unzip
checking for xargs... /usr/bin/xargs
checking for zip... /usr/bin/zip
checking for rpmbuild... /usr/bin/rpmbuild
Refreshing /builds/slave/c-cen-t-lnx/build/mozilla/old-configure with /usr/bin/autoconf-2.13
creating cache ./config.cache
checking host system type... i686-pc-linux-gnu
checking target system type... i686-pc-linux-gnu
checking build system type... i686-pc-linux-gnu
checking for objcopy... /builds/slave/c-cen-t-lnx/build/gcc/bin/objcopy
checking for gcc... /builds/slave/c-cen-t-lnx/build/mozilla/gcc/bin/gcc -m32 -march=pentiumpro
checking whether the C compiler (/builds/slave/c-cen-t-lnx/build/mozilla/gcc/bin/gcc -m32 -march=pentiumpro -gdwarf-2 -L/builds/slave/c-cen-t-lnx/build/gtk3/usr/local/lib ) works... no
configure: error: installation or configuration problem: C compiler cannot create executables.
DEBUG: This file contains any messages produced by compilers while
DEBUG: running configure, to aid debugging if configure makes a mistake.
DEBUG: 

It's using build/mozilla/gcc/bin/gcc which is wrong.  It should be using 
build/gcc/bin/gcc.

Comment 1

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] proposed patch (v1)

Comment 2

[Edmund Wong (:ewong)]

Attachment: [m-c] copy TOOLTOOL_DIR to mozconfig.linux (v1)

Comment 3

[Edmund Wong (:ewong)]

Attachment: [c-c] sync mozconfig.linux

Comment 4

[Edmund Wong (:ewong)]

Comment on attachment 8738368 [details] [diff] [review]
[m-c] copy TOOLTOOL_DIR to mozconfig.linux (v1)

Pushed to try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c14fbbb5a9a2acd985a7d25a9c415e66455a7ba

Comment 5

[Magnus Melin [:mkmelin]]

The remaining part of bug 1254987 I suppose.

Comment 6

[Edmund Wong (:ewong)]

Attachment: [m-c] copy TOOLTOOL_DIR to mozconfig.linux (v2)

I think it helps to have the right patch attached.

Comment 7

[Jorg K (CEST = GMT+2)]

Hey Edmund, thanks for looking into it. Very much appreciated!

Comment 8

[aleth [:aleth]]

Comment on attachment 8738460 [details] [diff] [review]
[m-c] copy TOOLTOOL_DIR to mozconfig.linux (v2)

Review of attachment 8738460 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this might be a workaround until bug 1259382 lands!

::: build/unix/mozconfig.linux
@@ +20,4 @@
>  
>    # We want to make sure we use binutils and other binaries in the tooltool
>    # package.
>    mk_add_options PATH="$topsrcdir/gcc/bin:$PATH"

Don't you need to change this line as well?

Comment 9

[aleth [:aleth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf6b234a30fd

Comment 10

[Edmund Wong (:ewong)]

Attachment: [m-i] copy TOOLTOOL_DIR to mozconfig.linux (v3)

Comment 11

[Edmund Wong (:ewong)]

Attachment: [c-c] sync mozconfig.linux (v2)

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e40e61c0522

Comment 13

[aleth [:aleth]]

Given the try run in comment 9, I'm not sure this will actually fix Linux on c-c, but let's hope for the best!

Comment 14

[Edmund Wong (:ewong)]

(In reply to aleth [:aleth] from comment #13)
> Given the try run in comment 9, I'm not sure this will actually fix Linux on
> c-c, but let's hope for the best!

the try run on c-c was due to some 'badness' |make buildsymbols| and
not the compile step.  The bustage is mainly (from what :glandium suggests)
some confusion in which python is used.

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0e40e61c0522

Comment 16

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/46cf4e453709bf7a045a895a9e5cefaa23f537cd
Keep build/ in sync: Bug 1262057 - Find gcc using TOOLTOOL_DIR. rs=bustage-fix CLOSED TREE

Comment 17

[aleth [:aleth]]

(In reply to Edmund Wong (:ewong) from comment #14)
> (In reply to aleth [:aleth] from comment #13)
> > Given the try run in comment 9, I'm not sure this will actually fix Linux on
> > c-c, but let's hope for the best!
> 
> the try run on c-c was due to some 'badness' |make buildsymbols| and
> not the compile step.  The bustage is mainly (from what :glandium suggests)
> some confusion in which python is used.

Right, I just meant I'm not sure we'll get a green build on treeherder ;)

Thanks!

Comment 18

[Edmund Wong (:ewong)]

(In reply to aleth [:aleth] from comment #17)
> (In reply to Edmund Wong (:ewong) from comment #14)
> > (In reply to aleth [:aleth] from comment #13)
> > > Given the try run in comment 9, I'm not sure this will actually fix Linux on
> > > c-c, but let's hope for the best!
> > 
> > the try run on c-c was due to some 'badness' |make buildsymbols| and
> > not the compile step.  The bustage is mainly (from what :glandium suggests)
> > some confusion in which python is used.
> 
> Right, I just meant I'm not sure we'll get a green build on treeherder ;)
> 
> Thanks!

The green build will most probably require some finess with the buildbotcustom
code.