1262088 - Incorrect about:memory reports (gfx/heap-textures) when playing HTML5 videos

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect, P1)

Description

[rhazor]

Attachment: 6gb leak

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160315153207

Steps to reproduce:

Upgraded to Win10, clean install Firefox.
Addons: uBlock Origin, Ghostery, HTTPS-Everywhere, Feed Sidebar, RightBar, Add Bookmark Here, Web Developer, FFZ, BTTV.
Had same addons on Win8 no problem.
Plus had MemoryFox that used to keep Firefox at ~300-400MB, but the addon is gone from the addons.mozilla.org website


Actual results:

In Task Manager now I got firefox.exe at 1GB of RAM and in about:memory 6GB of RAM
https://imgur.com/Nqpsd2B
https://imgur.com/7MMKCTR


Expected results:

I don't know, maybe eat less memory?

Comment 1

[rhazor]

OK, I tracked down the leak. Which by the way keeps increasing infinite as long as the YouTube HTML5 play/videos are playing.

So the leak is caused by HTML5 videos.

I'm sure of that, because I disabled YouTube's HTML5 player and switched to Flash player and now the gfx/heap-textures are at 15MB! and not 6000MB (earlier today I actually reached 15,000MB!)

So, problem is with HTML5 videos.

I did update my ffmpeg to latest x64 build (as my browser is also x64).

For now, I'm just stick with the good old flash until anyone cares to investigating this.

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Matt - thoughts?

Comment 3

[Matt Woodrow (:mattwoodrow)]

Can you post the graphics section of about:support please.

Firefox should be using WMF to decode video, not ffmpeg, so that is unlikely to make any difference.

Comment 4

[rhazor]

https://i.imgur.com/IxdasBl.png

Comment 5

[Benedikt Pfeifer]

There's a negative measurement (-6181.11MB ) in the "heap-textures" reporter. With that, the numbers in attachment 8738073 [details] almost sum up nicely (difference < 0.1MB iirc).

Could it be that the total ("explicit") and the values for the categories except "heap-unclassified" are actually measured and that "heap-unclassified" is simply the difference of that? 

I'm seeing such a huge "heap-unclassified" value (~ 15GB) in my current Firefox session as well. Same culprit here: "-15,187.97 MB (-751.13%) ── heap-textures [?!]". The amount of memory of the first level children of "explicit" almost sum up too (within a difference of 0.2MB here)), so I'll change this bug from UNCONFIRMED to NEW.

Comment 6

[Matt Woodrow (:mattwoodrow)]

I didn't notice that it was negative, that's interesting. It's likely that this is just a reporting bug, and not a real leak, but we'll see.

Nical, any ideas here?

Both places we call GfxMemoryImageReporter::WillFree, we also explicitly delete the buffer, so it seems unlikely that we're double calling that.

I can't see any way we're missing the DidAlloc call either though.

Comment 7

[Nicolas Silva [:nical]]

I don't have any idea off hands and I am pretty busy with shutdown/e10s stuff right now so I will probably not look at this in the very short term.

Comment 8

[Matt Woodrow (:mattwoodrow)]

Does this bug still reproduce on Firefox Nightly without any addons installed?

I'm having trouble reproducing it on my machine.

Can you please also right-click on a playing youtube video, select 'stats for nerds' and then paste that information (from a build that reproduces the issue).

Thanks!

Comment 9

[rhazor]

With Nightfly x64 I got no issues, seems to be all working and even with ALL extensions enabled.

Infos from Firefox:
Stats for nerds:
Video ID:
OCn4jqx-Bsg
Dimensions:
854 x 480
Resolution:
1920 x 1080@25
Volume:
55%
Stream Host:
r2---sn-uxv-8ovl
Stream Type:
https
CPN:
9BbEHEbugncYn4qf
Mime Type:
video/webm; codecs="vp9"
DASH:
yes (248/251)
Connection Speed:
65549 Kbps
Dropped Frames:
0/3552

Debug info:
{"ns":"yt","el":"detailpage","cpn":"9BbEHEbugncYn4qf","docid":"OCn4jqx-Bsg","ver":2,"referrer":"https://www.youtube.com/feed/subscriptions","cmt":"98.721","plid":"AAUxDUsSXSiQMWGz","ei":"j8oZV4z4D5CTdJbBsrAF","fmt":"248","fs":"0","rt":"99.346","of":"w3gaIloOh0ZVMxqkcOBnTw","adformat":null,"content_v":null,"euri":"","subscribed":"1","lact":2,"live":null,"cl":"120363539","mos":1,"osid":null,"state":"8","vm":"CAIQAQ","volume":55,"c":"WEB","cver":"1.20160420","cplayer":"UNIPLAYER","cbr":"Firefox","cbrver":"45.0","cos":"Windows","cosver":"10.0","hl":"en_US","cr":"LT","len":"3968.921","fexp":"9406985,9416126,9416891,9420452,9422596,9426927,9428398,9431012,9433097,9433947","feature":"atom-subs","afmt":"251","vct":"98.721","vd":"3968.921","vpl":"0.000-98.721,","vbu":"0.000-148.480,","vpa":false,"vsk":false,"ven":false,"vpr":1,"vrs":4,"vns":2,"vec":null,"vvol":0.55,"lct":"98.721","lsk":false,"lmf":false,"lbw":"8193511.439","lhd":"0.096","ltd":"0.359","laa":"itag=251,seg=14,range=2310751-2392275,time=143.4-148.5","lva":"itag=248,seg=28,range=37112666-39039070,time=143.4-148.5","lar":"itag=251,seg=16,range=2577078-2731544,time=160.0-170.0","lvr":"itag=248,seg=30,range=41075939-42772282,time=153.6-158.7","lvh":"r2---sn-uxv-8ovl","lab":"0.000-148.481,","lvb":"0.000-148.480,","ismb":24330000,"debug_videoId":"OCn4jqx-Bsg","cgr":true,"debug_playbackQuality":"hd1080","debug_date":"Fri Apr 22 2016 09:55:24 GMT+0300 (FLE Standard Time)"}

Comment 10

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to matas from comment #9)
> With Nightfly x64 I got no issues, seems to be all working and even with ALL
> extensions enabled.