1262219 - Get dialer app working as chrome

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Ben Francis [:benfrancis]]

Get the dialer app work as chrome://

Comment 1

[Ben Francis [:benfrancis]]

Hi Gabriele, are you working on this bug?

Comment 2

[Gabriele Svelto [:gsvelto]]

Yes, but progress has been very slow. For now I only have a stand-alone dialer (i.e. without the contacts part) but I cannot still get it to work in chrome.

Comment 3

[Alberto Pastor [:albertopq]]

Made some progress on this. First outgoing call should work already -> https://github.com/albertopq/gaia/tree/dialer

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:dialer > mozilla-b2g:kanikani

Comment 5

[Alberto Pastor [:albertopq]]

Comment on attachment 8759611 [details] [review]
[gaia] albertopq:dialer > mozilla-b2g:kanikani

Grabiele, would you mind to take a look? 4 main changes:

- Created the dialer as standalone app (manifest, paths, etc)
- Changed the paths to the shared directory
- Adapted the postMessages between callscreen and dialer to the new origin
- Replaced system messages with ChromeEvents.

Let me know if you have any question.

Thanks!

Comment 6

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8759611 [details] [review]
[gaia] albertopq:dialer > mozilla-b2g:kanikani

Looking very good, I've just left a couple of notes in the PR. On a side note: I've noticed you left the contacts button in the navigation bar, do you intend to bring back contacts too? If that's not the case then I'd suggest to just remove that button for now.

Last but not least, one of the issues we should have due to the lack of system messages is that the app cannot be auto-launched when a new call comes in. IIRC that should be fixable by intercepting the telephony-new-call message in the system app and then launching the dialer from there. The callscreen is smart enough to "poll" the call state when it's launched so even though it might start a while after the event changes in the telephony objects happened it will still launch and display the new call correctly.

Comment 7

[Alberto Pastor [:albertopq]]

kanikani: https://github.com/mozilla-b2g/gaia/commit/a327ddbf0e0adbc58d837b41718ca7542b5e3a66