1262249 - .bash_profile is executed twice

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Kelsey Gilbert [:jgilbert]]

I noticed this when adding "eval ssh-agent" and ssh-add to my .bash_profile, and found that it ran twice.

I found that it's called once in /msys/etc/profile.h/profile-homedir.sh, and commented that out. This seems to work.

After trying this, I greped:
mozilla-win-199981@jgilbert-mbp /c/mozilla-build-2-2-0
$ grep -nr '[.]bash_profile' ./msys
Binary file ./msys/bin/bash.exe matches
Binary file ./msys/bin/sh.exe matches
./msys/etc/profile.d/profile-homedir.sh:8:#if test -f "$HOME/.bash_profile"; then
./msys/etc/profile.d/profile-homedir.sh:9:#    . "$HOME/.bash_profile"

Possibly it's being run by one of bash.exe or sh.exe as well?

Comment 1

[Ryan VanderMeulen [:RyanVM]]

start-shell.bat calls bash with the --login flag, which loads .bash_profile per the docs I've found on it. I'll remove the extraneous one from profile-homedir.sh.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/28c0512ff26b
Remove the unnecessary call to .bash_profile in profile-homedir.sh.