Closed
Bug 1262331
Opened 9 years ago
Closed 9 years ago
mach valgrind-test eats first lines of stack traces
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Valgrind-test's output handler buffers valgrind's output to detect
errors and emit proper messages that are detected by automation log
parsing. When an error is detected, the buffered output is reinjected,
but there was a typo that prevented that from actually happening,
which ate the first lines of stack traces.
Review commit: https://reviewboard.mozilla.org/r/44475/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44475/
Attachment #8738354 -
Flags: review?(gps)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8738354 [details]
MozReview Request: Bug 1262331 - Fix mach valgrind-test logging
https://reviewboard.mozilla.org/r/44475/#review41271
Attachment #8738354 -
Flags: review?(gps) → review+
|
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•