mach valgrind-test eats first lines of stack traces

RESOLVED FIXED in Firefox 48

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla48

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8738354 [details]
MozReview Request: Bug 1262331 - Fix mach valgrind-test logging

Valgrind-test's output handler buffers valgrind's output to detect
errors and emit proper messages that are detected by automation log
parsing. When an error is detected, the buffered output is reinjected,
but there was a typo that prevented that from actually happening,
which ate the first lines of stack traces.

Review commit: https://reviewboard.mozilla.org/r/44475/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44475/
Attachment #8738354 - Flags: review?(gps)

Comment 2

2 years ago
Comment on attachment 8738354 [details]
MozReview Request: Bug 1262331 - Fix mach valgrind-test logging

https://reviewboard.mozilla.org/r/44475/#review41271
Attachment #8738354 - Flags: review?(gps) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d6d31b41c2f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.