1262363 - [ATOK for Mac: Japanese Input Method] Send mouse events to Input Method to allow they can use it for UI state control (c.f. close automatic suggestion window by clicking another place).

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Kenji IRIE]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160405030214

Steps to reproduce:

I've confirmed the concrete problem only with ATOK for Mac (a commercial IM in Japan) and Firefox combination.

Configure ATOK for Mac as following:
0. Install ATOK 2015 for Mac.
1. Open "ATOK 環境設定" from "環境設定" input menu item.
2. Select "推測変換" item in "設定項目" configuration tree.
3. Turn the "確定直後に推測候補の自動表示を行う" setting ON.
4. Press "OK" to close configuration dialog.

With this configuration, after you commited a word with ATOK, automatically opened continueing word suggestion window.

Clicking browser window should close the suggestion window.




Actual results:

With Firefox, it (the window) leaves.


Expected results:

Like other browsers than Firefox, clicking browser window should close the suggestion window.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Hmm, I don't have ATOK 2015 for Mac. Makoto-san, do you?

# If not, I'll get it.

Comment 2

[Kenji IRIE]

Older version of ATOK for Mac should reproduce this.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Oh, okay, thanks. I'll try to test it when I have much time.

Comment 4

[Makoto Kato [:m_kato] (PTO until 5/6)]

I have ATOK subscription.  I test this this week.

Comment 5

[Kenji IRIE]

Sorry, You need ATOK 2012 for Mac or later versions to reproduce this.

Comment 6

[Makoto Kato [:m_kato] (PTO until 5/6)]

Tested on 10.10 with ATOK 2015.

Comment 7

[Makoto Kato [:m_kato] (PTO until 5/6)]

Although I doesn't create patch yet, we should call [NSTextInputContext deactive] when blur?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

(In reply to Makoto Kato [:m_kato] from comment #7)
> Although I doesn't create patch yet, we should call [NSTextInputContext
> deactive] when blur?

Basically, I hope that it's not so because the document said "You should not call this method directly; it is invoked by the system. It is provided as an override point for subclasses". So, I'm afraid to call it by ourselves...

Comment 9

[Kenji IRIE]

I expect Gecko send (probably all) mouse events to [NSTextInputContext handleEvent:] before/after Gecko handles it.
Then ATOK can dismiss automatic suggestion window by handling it.

https://developer.apple.com/library/mac/documentation/Cocoa/Reference/NSTextInputContext_Class/#//apple_ref/occ/instm/NSTextInputContext/handleEvent:

Comment 10

[Makoto Kato [:m_kato] (PTO until 5/6)]

Webkit2 handles same method for mouse.  Thanks, Irie-san.

Comment 11

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: MozReview Request: Bug 1262363 - Call [NSTextInputContext handleEvent] for mouse support on IME. r?masayuki

Some IME handles mouse event by handleEvent method of NSTextInputcontext.  So we should call it on mouse event for IME

Review commit: https://reviewboard.mozilla.org/r/49357/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49357/

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Comment on attachment 8746307 [details]
MozReview Request: Bug 1262363 - Call [NSTextInputContext handleEvent] for mouse support on IME. r?masayuki

https://reviewboard.mozilla.org/r/49357/#review46245

Thank you very much!

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfd20783b793

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfd20783b793

Comment 15

[Kenji IRIE]

I've verified the problem is fixed with Nightly (49.0a1 (2016-05-08)).
Thank you very much!